-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: mandate abi
in Predicate
constructor
#3387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
CodSpeed Performance ReportMerging #3387 will improve performances by ×2.5Comparing Summary
Benchmarks breakdown
|
nedsalk
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
petertonysmith94 and
maschad
as code owners
November 12, 2024 17:19
4 tasks
danielbate
approved these changes
Nov 12, 2024
danielbate
reviewed
Nov 12, 2024
Torres-ssf
requested review from
arthurgeron,
luizstacio,
helciofranco and
LuizAsFight
November 13, 2024 01:45
petertonysmith94
approved these changes
Nov 13, 2024
Dhaiwat10
approved these changes
Nov 13, 2024
Coverage Report:
Changed Files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abi
a required parameter on thePredicate
constructor #1843Summary
This PR makes the
abi
parameter mandatory onPredicate
instantiation and removes tests that test if it wasn't provided.Breaking Changes
Instantiating a
Predicate
now requires providing itsabi
. If you want to use thePredicate
as anAccount
, please instantiate it via theAccount
classChecklist