Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cache latest fuels version #3350

Merged
merged 25 commits into from
Oct 30, 2024
Merged

feat: cache latest fuels version #3350

merged 25 commits into from
Oct 30, 2024

Conversation

Dhaiwat10
Copy link
Member

Closes TS-654

Summary

This PR adds a basic local cache for the latest fuels version fetched by the fuels CLI.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Dhaiwat10 Dhaiwat10 self-assigned this Oct 21, 2024
@github-actions github-actions bot added the feat Issue is a feature label Oct 21, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 8:21am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 8:21am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ts-docs-api ⬜️ Ignored (Inspect) Oct 30, 2024 8:21am

@Dhaiwat10 Dhaiwat10 changed the title feat: cache latest fuels version feat: cache latest fuels version Oct 21, 2024
@Dhaiwat10 Dhaiwat10 marked this pull request as draft October 21, 2024 15:40
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 21, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3350 will not alter performance

Comparing dp/fuels-version-cache (a6aaef2) with master (e55aaca)

Summary

✅ 18 untouched benchmarks

@Dhaiwat10 Dhaiwat10 marked this pull request as ready for review October 22, 2024 11:27
Torres-ssf
Torres-ssf reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Torres-ssf Torres-ssf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 👏

packages/fuels/src/cli/utils/getLatestFuelsVersion.ts Outdated Show resolved Hide resolved
packages/fuels/src/cli/utils/fuelsVersionCache.ts Show resolved Hide resolved
packages/fuels/src/cli/utils/fuelsVersionCache.ts Show resolved Hide resolved
maschad
maschad approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@maschad maschad enabled auto-merge (squash) October 30, 2024 08:17
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
70.26%(+0.06%) 69.97%(+0.07%) 74.51%(+0.05%) 70.56%(+0.06%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
✅ ✨ packages/fuels/src/cli/utils/fuelsVersionCache.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
🔴 ✨ packages/fuels/src/cli/utils/getLatestFuelsVersion.ts 91.66%
(+91.66%)		 75%
(+75%)		 100%
(+100%)		 92.3%
(+92.3%)

@maschad maschad merged commit f1500e4 into master Oct 30, 2024
25 checks passed
@maschad maschad deleted the dp/fuels-version-cache branch October 30, 2024 09:17
@fuel-service-user fuel-service-user mentioned this pull request Oct 30, 2024
Merged
Dhaiwat10 added a commit that referenced this pull request Nov 19, 2024
@Dhaiwat10 @petertonysmith94 @maschad
feat: cache latest fuels version (#3350)
cdf040a 
Co-authored-by: Peter Smith <[email protected]>
Co-authored-by: Chad Nehemiah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedsalk nedsalk nedsalk approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@maschad maschad maschad approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

Assignees

@Dhaiwat10 Dhaiwat10

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement caching to check latest fuels version
5 participants
@Dhaiwat10 @maschad @petertonysmith94 @nedsalk @Torres-ssf