-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: optimize coin gql queries #3301
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
CodSpeed Performance ReportMerging #3301 will not alter performanceComparing Summary
|
maschad
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
nedsalk and
petertonysmith94
as code owners
October 10, 2024 00:18
danielbate
requested changes
Oct 10, 2024
danielbate
changed the title
fix: optimize coin gql queries
fix!: optimize coin gql queries
Oct 10, 2024
danielbate
previously approved these changes
Oct 10, 2024
nedsalk
previously approved these changes
Oct 10, 2024
maschad
changed the title
chore!: optimize coin gql queries
chore: optimize coin gql queries
Nov 12, 2024
maschad
requested review from
petertonysmith94,
Dhaiwat10,
danielbate and
nedsalk
November 12, 2024 09:48
maschad
changed the title
chore: optimize coin gql queries
chore!: optimize coin gql queries
Nov 12, 2024
I've decided to restore the |
nedsalk
approved these changes
Nov 12, 2024
danielbate
approved these changes
Nov 12, 2024
Torres-ssf
approved these changes
Nov 13, 2024
Coverage Report:
Changed Files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
getCoins
provider endpointSummary
getCoin
gql query from the provider operations as it is unused in our SDK.owner
from thecoinFragment
as it can be populated in the calling functions for both:getCoins
getResourcesToSpend
Breaking Changes
The
Provider.operations.getCoins()
andProvider.operations.getCoinsToSpend
function no longer return the owner. These methods shouldn't be called directly but are used internally to formulate responses from the SDK.Removed the property
owner
from theProvider.operations.getCoinsToSpend()
function. Suggest to use the owner from the input parameters.Checklist