fix: typegen factory template #3274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Performance ReportMerging #3274 will not alter performanceComparing Summary
|
arboleya
requested review from
digorithm,
Torres-ssf,
Dhaiwat10,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
danielbate
approved these changes
Oct 8, 2024
nedsalk
requested changes
Oct 8, 2024
There was a problem hiding this comment.
@arboleya we might want want to add the noImplicitOverride compiler option to the tsconfig.base.json to further protect against this.
|
@nedsalk This will affect other parts of the codebase, but please feel free to do it in a follow-up PR. |
nedsalk
approved these changes
Oct 8, 2024
|
Coverage Report:
Changed Files:Coverage values did not change👌. |
Torres-ssf
approved these changes
Oct 8, 2024
Dhaiwat10
pushed a commit
that referenced
this pull request
Nov 19, 2024
* Adding [missing] override spec * Adding changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
ContractFactoryChecklist