Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add missing matcher #3247

Merged
merged 6 commits into from
Oct 6, 2024
Merged

feat: add missing matcher #3247

merged 6 commits into from
Oct 6, 2024

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Oct 4, 2024 •
edited by petertonysmith94
Loading

Summary

  • Adds missing str matcher to the sway type matchers.
  • Enables name to be extracted from the Struct and Enum regex.
  • Fixed issue whereby if a matcher was undefined, then it wouldn't be found.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@nedsalk nedsalk self-assigned this Oct 4, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 5:00pm
ts-api-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 5:00pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 5:00pm

@github-actions github-actions bot added the feat Issue is a feature label Oct 4, 2024
@nedsalk nedsalk changed the base branch from master to np/feat/abi-refactor October 4, 2024 15:37
@nedsalk nedsalk force-pushed the ns/feat/add-missing-matcher branch from 27055c6 to ead2f03 Compare October 4, 2024 16:50
@petertonysmith94 petertonysmith94 merged commit 976c1bd into np/feat/abi-refactor Oct 6, 2024
20 of 21 checks passed
@petertonysmith94 petertonysmith94 deleted the ns/feat/add-missing-matcher branch October 6, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@nedsalk nedsalk

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nedsalk @petertonysmith94