-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: calling prebuild
only if deps are installed
#3217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
This PR is published in NPM with version 0.0.0-pr-3217-20240926163336 |
…to st/fix/create-fuels
Torres-ssf
changed the title
fix: create-fuels
fix: prevent Sep 26, 2024
create-fiels
running prebuild
when deps are not installed
Torres-ssf
changed the title
fix: prevent
fix: prevent Sep 26, 2024
create-fiels
running prebuild
when deps are not installedcreate-fuels
running prebuild
when deps were not installed
Torres-ssf
requested review from
digorithm,
arboleya,
Dhaiwat10,
danielbate and
nedsalk
as code owners
September 26, 2024 17:23
Torres-ssf
requested review from
petertonysmith94 and
maschad
as code owners
September 26, 2024 17:23
Torres-ssf
changed the title
fix: prevent
fix: prevent create-fuels running Sep 26, 2024
create-fuels
running prebuild
when deps were not installedprebuild
when deps were not installed
Torres-ssf
changed the title
fix: prevent create-fuels running
fix: prevent create-fuels running prebuild when deps were not installed
Sep 26, 2024
prebuild
when deps were not installed
arboleya
reviewed
Sep 26, 2024
arboleya
changed the title
fix: prevent create-fuels running prebuild when deps were not installed
fix: calling Sep 26, 2024
prebuild
only if deps are installed
arboleya
approved these changes
Sep 26, 2024
maschad
approved these changes
Sep 26, 2024
danielbate
approved these changes
Sep 26, 2024
Coverage Report:
Changed Files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue related to calling the prebuild command in a newly bootstrapped
create-fuels
project. The prebuild command is intended to generate Typegen files, but it was also executed when dependencies were not installed due to the--no-install
flag.Checklist