Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag to indicate if connector is external #3201

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

arthurgeron
Copy link
Contributor

@arthurgeron arthurgeron commented Sep 22, 2024

Release notes

In this release, we:

  • Added flag to indicate whether the connector is external

Summary

Add external flag to differentiate between native and external connectors.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Sep 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 1:54pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 1:54pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 23, 2024 1:54pm

Copy link
Contributor

This PR is published in NPM with version 0.0.0-pr-3201-20240922225832

Copy link

codspeed-hq bot commented Sep 22, 2024

CodSpeed Performance Report

Merging #3201 will not alter performance

Comparing ag/feat/add-external-flag (3e4f18e) with master (ef50619)

Summary

✅ 21 untouched benchmarks

@arthurgeron arthurgeron enabled auto-merge (squash) September 23, 2024 03:43
@arthurgeron
Copy link
Contributor Author

@petertonysmith94
Could we please get 0.94.7 released after this is merged?

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.17%(+0.01%) 71.81%(+0%) 75.77%(+0%) 77.28%(+0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/connectors/fuel-connector.ts 28.57%
(+2.65%)
100%
(+0%)
4.76%
(+0%)
28.57%
(+2.65%)

@arthurgeron arthurgeron merged commit b869ee8 into master Sep 23, 2024
25 checks passed
@arthurgeron arthurgeron deleted the ag/feat/add-external-flag branch September 23, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants