Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provider.url now returns auth url #3147

Merged
merged 8 commits into from
Sep 11, 2024
Merged

feat: provider.url now returns auth url #3147

merged 8 commits into from
Sep 11, 2024

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Sep 11, 2024 •
edited by arboleya
Loading

Release notes

In this release, we:

  • The provider.url now returns an authenticated URL
  • The Provider now accepts a headers field

Summary

  • Provider.connect was not working with the authentication URL, so that is also working now.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the feat Issue is a feature label Sep 11, 2024
@petertonysmith94 petertonysmith94 self-assigned this Sep 11, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 4:46pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 4:46pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 11, 2024 4:46pm

@petertonysmith94 petertonysmith94 marked this pull request as ready for review September 11, 2024 15:06
arboleya
arboleya approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Headers, of course! ⚡ ✨ 🎯

@arboleya arboleya enabled auto-merge (squash) September 11, 2024 16:28
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
78.87%(+0.01%) 71.75%(+0%) 77.19%(-0.01%) 78.95%(+0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 71.36%
(+0.21%)		 64.17%
(-0.7%)		 73.91%
(-0.28%)		 70.99%
(+0.2%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)		 78.08%
(+1.37%)		 84%
(+0%)		 88.81%
(+0%)

@arboleya arboleya merged commit aef7282 into master Sep 11, 2024
23 checks passed
@arboleya arboleya deleted the ps/feat/provider-url-now-returns-auth-url branch September 11, 2024 17:22
@fuel-service-user fuel-service-user mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@maschad maschad maschad approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

this.provider.url is not considering auth url passed
4 participants
@petertonysmith94 @arboleya @maschad @Torres-ssf