Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: inform users if their fuels version is outdated #3108

Merged
merged 28 commits into from
Sep 16, 2024
Merged

chore: inform users if their fuels version is outdated #3108

merged 28 commits into from
Sep 16, 2024

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Sep 5, 2024 •
edited
Loading

Closes #2968

Release notes

In this release, we:

  • Added a banner for users running an outdated fuels version

Summary

This PR adds a feature in the fuels CLI regarding the user's fuels version. If the user's installed fuels version is outdated, the CLI will print out the latest version for the user.

Breaking Changes

runVersions is now async.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@vercel Vercel
Copy link

vercel bot commented Sep 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 0:22am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 0:22am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 16, 2024 0:22am

@Dhaiwat10 Dhaiwat10 changed the title test reportUserVersion chore: inform users is their fuels verison is outdated Sep 5, 2024
@Dhaiwat10 Dhaiwat10 changed the title chore: inform users is their fuels verison is outdated chore: inform users if their fuels verison is outdated Sep 5, 2024
@github-actions github-actions bot added the chore Issue is a chore label Sep 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited
Loading

This PR is published in NPM with version 0.0.0-pr-3108-20240911163102

@arboleya arboleya changed the title chore: inform users if their fuels verison is outdated chore: inform users if their fuels version is outdated Sep 11, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Sep 11, 2024
maschad
maschad reviewed Sep 14, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Dhaiwat10 LGTM but left one comment

@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) September 16, 2024 12:18
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.13%(+0.05%) 71.63%(-0.01%) 75.77%(+0.04%) 77.24%(+0.05%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)		 76.71%
(-1.37%)		 84%
(+0%)		 88.81%
(+0%)
🔴 ✨ packages/fuels/src/cli/utils/checkForAndDisplayUpdates.ts 100%
(+100%)		 83.33%
(+83.33%)		 100%
(+100%)		 100%
(+100%)

@Dhaiwat10 Dhaiwat10 merged commit 431990d into master Sep 16, 2024
25 of 26 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/outdated-fuels-banner branch September 16, 2024 12:38
@fuel-service-user fuel-service-user mentioned this pull request Sep 16, 2024
Merged
nedsalk pushed a commit that referenced this pull request Sep 17, 2024
@Dhaiwat10 @maschad @nedsalk
chore: inform users if their fuels version is outdated (#3108)
5e55da8 
* test `reportUserVersion`

* move util to `versions` package

* export via cli and not index

* log fuels version

* fetch latest version

* log out comparison

* add changeset

* fix tests

* disable pr release

* add tests

* re-use `getBuiltinVersions`

* move to `fuels` CLI from `versions`

* revert test changes

* revert tests

* add tests

* add testing group

* add changeset

* add a test case

* print a msg if fetch fails

* add error msg in one more place

* fix test

---------

Co-authored-by: Chad Nehemiah <[email protected]>
@Dhaiwat10 Dhaiwat10 mentioned this pull request Sep 17, 2024
Closed
@arboleya arboleya mentioned this pull request Sep 19, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya left review comments

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@Dhaiwat10 Dhaiwat10

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inform users if their fuels version is outdated
6 participants
@Dhaiwat10 @petertonysmith94 @arboleya @danielbate @maschad @Torres-ssf