Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support basic auth #3079

Merged
merged 6 commits into from
Sep 3, 2024
Merged

feat: support basic auth #3079

merged 6 commits into from
Sep 3, 2024

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Sep 2, 2024 •
edited by arboleya
Loading

Release notes

In this release, we:

  • Added support for URLs with BasicAuth credentials in Provider

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@nedsalk nedsalk added the feat Issue is a feature label Sep 2, 2024
@nedsalk nedsalk self-assigned this Sep 2, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 5:22am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 5:22am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 3, 2024 5:22am

@nedsalk nedsalk marked this pull request as ready for review September 2, 2024 15:10
@nedsalk nedsalk enabled auto-merge (squash) September 2, 2024 15:26
arboleya
arboleya requested changes Sep 2, 2024
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of suggestions to simplify the flow.

Pseudo-code, pls double-check.

packages/account/src/providers/provider.ts Outdated Show resolved Hide resolved
packages/account/src/providers/provider.ts Outdated Show resolved Hide resolved
packages/account/src/providers/provider.ts Outdated Show resolved Hide resolved
packages/account/src/providers/provider.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Coverage Report:

Lines Branches Functions Statements
79.58%(+0.03%) 71.99%(+0.12%) 78.02%(+0.02%) 79.71%(+0.03%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 71.42%
(+0.96%)		 63.18%
(+1.53%)		 76.74%
(+0.55%)		 71.32%
(+0.95%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.48%
(+0%)		 79.71%
(+1.45%)		 84%
(+0%)		 88.73%
(+0%)

@nedsalk nedsalk merged commit 90a1d0f into master Sep 3, 2024
23 checks passed
@nedsalk nedsalk deleted the ns/feat/basic-auth branch September 3, 2024 11:11
@fuel-service-user fuel-service-user mentioned this pull request Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@nedsalk nedsalk

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider handling BasicAuth credentials in Provider
5 participants
@nedsalk @arboleya @danielbate @petertonysmith94 @Torres-ssf