Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flaky faucet test #2542

Merged
merged 6 commits into from
Jun 18, 2024
Merged

fix: flaky faucet test #2542

merged 6 commits into from
Jun 18, 2024

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 added the bug Issue is a bug label Jun 18, 2024
@petertonysmith94 petertonysmith94 added this to the 0.x mainnet milestone Jun 18, 2024
@petertonysmith94 petertonysmith94 self-assigned this Jun 18, 2024
petertonysmith94
petertonysmith94 commented Jun 18, 2024
View reviewed changes
Copy link
Contributor Author

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue here was the receiverAddress wasn't being updated if the wallet changed, see here.

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
45.57%(+0%) 38.88%(+0%) 42.2%(+0%) 45.34%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 enabled auto-merge (squash) June 18, 2024 08:31
@petertonysmith94 petertonysmith94 merged commit 977d58b into master Jun 18, 2024
27 of 28 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/fix/flaky-faucet-test branch June 18, 2024 10:53
@fuel-service-user fuel-service-user mentioned this pull request Jun 18, 2024
Merged
@maschad maschad mentioned this pull request Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
bug Issue is a bug
Projects
None yet
Milestone
0.x mainnet
Development

Successfully merging this pull request may close these issues.

Fix Flakey top-UI wallet integration test
4 participants
@petertonysmith94 @arboleya @danielbate @Torres-ssf