Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support mixed native and non-native enums #2501

Merged
merged 8 commits into from
Jun 13, 2024
Merged

feat: support mixed native and non-native enums #2501

merged 8 commits into from
Jun 13, 2024

Conversation

danielbate
Copy link
Contributor

Closes #2500

@danielbate danielbate added feat Issue is a feature p0 labels Jun 12, 2024
@danielbate danielbate added this to the 0.x mainnet milestone Jun 12, 2024
@danielbate danielbate self-assigned this Jun 12, 2024
@danielbate danielbate marked this pull request as draft June 12, 2024 15:20
@danielbate danielbate marked this pull request as ready for review June 12, 2024 15:26
nedsalk
nedsalk previously approved these changes Jun 12, 2024
View reviewed changes
@petertonysmith94 petertonysmith94 dismissed their stale review June 12, 2024 15:55

Premature approval

@arboleya arboleya removed the p0 label Jun 12, 2024
@danielbate @petertonysmith94
chore: use coder constant
446abd0 
Co-authored-by: Peter Smith <[email protected]>
petertonysmith94
petertonysmith94 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let go! 📈

@danielbate danielbate enabled auto-merge (squash) June 13, 2024 09:23
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
45.56%(+0.12%) 38.78%(+0.21%) 42.15%(-0.08%) 45.32%(+0.11%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/abi-coder/src/encoding/coders/EnumCoder.ts 95.91%
(+16.75%)		 92.85%
(+15.93%)		 100%
(+0%)		 95.91%
(+16.75%)

@danielbate danielbate merged commit 436f040 into master Jun 13, 2024
20 checks passed
@danielbate danielbate deleted the db/feat/support-mixed-native-enums branch June 13, 2024 14:54
@fuel-service-user fuel-service-user mentioned this pull request Jun 13, 2024
Merged
maschad pushed a commit that referenced this pull request Jun 17, 2024
@danielbate @petertonysmith94 @maschad
feat: support mixed native and non-native enums (#2501)
0c104ee 
* feat: support mixed native and non native enums

* chore: changeset

* chore: rearrange tests

* chore: use coder constant

Co-authored-by: Peter Smith <[email protected]>

---------

Co-authored-by: Peter Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedsalk nedsalk nedsalk approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@maschad maschad maschad approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

Assignees

@danielbate danielbate

Labels
feat Issue is a feature
Projects
None yet
Milestone
0.x mainnet
Development

Successfully merging this pull request may close these issues.

Support mixed native and non-native enums
5 participants
@danielbate @maschad @petertonysmith94 @nedsalk @arboleya