Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement generateFakeResources on Account class #2351

Merged
merged 36 commits into from
Jun 6, 2024
Merged

feat: implement generateFakeResources on Account class #2351

merged 36 commits into from
Jun 6, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented May 20, 2024 •
edited
Loading

After the changes made in this PR we can work on: #2362

@Torres-ssf Torres-ssf added the feat Issue is a feature label May 20, 2024
@Torres-ssf Torres-ssf self-assigned this May 20, 2024
@Torres-ssf Torres-ssf marked this pull request as ready for review May 21, 2024 17:30
maschad
maschad requested changes May 21, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on this, we should definitely document as this is useful for a few scenarios.

packages/account/src/account.ts Show resolved Hide resolved
packages/account/src/predicate/predicate.ts Show resolved Hide resolved
petertonysmith94
petertonysmith94 previously approved these changes May 23, 2024
View reviewed changes
packages/account/src/account.test.ts Outdated Show resolved Hide resolved
@Torres-ssf Torres-ssf requested a review from maschad May 29, 2024 12:34
nedsalk
nedsalk previously approved these changes May 30, 2024
View reviewed changes
@Torres-ssf Torres-ssf dismissed stale reviews from nedsalk and petertonysmith94 via 8955f97 May 30, 2024 15:28
@Torres-ssf Torres-ssf enabled auto-merge (squash) May 30, 2024 15:45
@maschad maschad requested a review from danielbate June 4, 2024 15:32
arboleya
arboleya reviewed Jun 5, 2024
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second what @danielbate said here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Coverage Report:

Lines Branches Functions Statements
46.16%(-0.19%) 39.61%(+0.02%) 43.27%(-0.24%) 45.98%(-0.19%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/account.ts 42.42%
(-0.26%)		 26.86%
(+0%)		 45.45%
(-2.93%)		 42.26%
(-0.51%)
🔴 packages/account/src/predicate/predicate.ts 23.8%
(-0.39%)		 31.25%
(+0%)		 11.76%
(-1.57%)		 22.38%
(-0.69%)
🔴 ✨ packages/create-fuels/scripts/prepublish.ts 0%
(+0%)		 100%
(+100%)		 100%
(+100%)		 0%
(+0%)
🔴 ✨ packages/create-fuels/src/lib/getPackageManager.ts 0%
(+0%)		 0%
(+0%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ packages/create-fuels/src/lib/rewriteTemplateFiles.ts 0%
(+0%)		 100%
(+100%)		 0%
(+0%)		 0%
(+0%)

@Torres-ssf Torres-ssf merged commit b1dbe42 into master Jun 6, 2024
20 checks passed
@Torres-ssf Torres-ssf deleted the st/feat/add-generate-fake-resources-to-account branch June 6, 2024 16:02
@fuel-service-user fuel-service-user mentioned this pull request Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@nedsalk nedsalk nedsalk approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Generate Fake Resources Into Account Class
7 participants
@Torres-ssf @arboleya @danielbate @maschad @petertonysmith94 @nedsalk @Dhaiwat10