Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for bun #2350

Merged
merged 53 commits into from
Jun 6, 2024
Merged

feat: support for bun #2350

merged 53 commits into from
Jun 6, 2024

Conversation

petertonysmith94
Copy link
Contributor

Closes #1598

@petertonysmith94 petertonysmith94 added the feat Issue is a feature label May 20, 2024
@petertonysmith94 petertonysmith94 self-assigned this May 20, 2024
@petertonysmith94
Copy link
Contributor Author

Integrate into our testing suite #2265

@petertonysmith94 petertonysmith94 marked this pull request as ready for review May 23, 2024 12:57
arboleya
arboleya previously approved these changes May 30, 2024
View reviewed changes
Dhaiwat10
Dhaiwat10 previously approved these changes May 30, 2024
View reviewed changes
danielbate
danielbate previously approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with nits 🤔

apps/demo-bun-fuels/package.json Show resolved Hide resolved
apps/demo-bun-fuels/src/bun.test.ts Outdated Show resolved Hide resolved
maschad
maschad previously approved these changes May 31, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Coverage Report:

Lines Branches Functions Statements
46.17%(-0.18%) 39.61%(+0.02%) 43.38%(-0.13%) 46%(-0.17%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 ✨ packages/create-fuels/scripts/prepublish.ts 0%
(+0%)		 100%
(+100%)		 100%
(+100%)		 0%
(+0%)
🔴 ✨ packages/create-fuels/src/lib/getPackageManager.ts 0%
(+0%)		 0%
(+0%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ packages/create-fuels/src/lib/rewriteTemplateFiles.ts 0%
(+0%)		 100%
(+100%)		 0%
(+0%)		 0%
(+0%)

@petertonysmith94 petertonysmith94 merged commit af3202c into master Jun 6, 2024
19 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/feat/bun-fuels branch June 6, 2024 15:18
@fuel-service-user fuel-service-user mentioned this pull request Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@nedsalk nedsalk nedsalk approved these changes

@arboleya arboleya arboleya approved these changes

@maschad maschad maschad left review comments

@danielbate danielbate danielbate left review comments

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure bun support
6 participants
@petertonysmith94 @maschad @arboleya @danielbate @nedsalk @Dhaiwat10