fix!: remove offset from decodeLog and decodeFunctionResult methods

.changeset/perfect-kings-camp.md

@@ -0,0 +1,5 @@
+---
+"@fuel-ts/abi-coder": minor
+---
+
+fix: Changed decodeLog and decodeFunctionResult return types to have only decoded value without an offset

packages/abi-coder/src/Interface.ts

@@ -45,7 +45,7 @@ export class Interface<TAbi extends JsonAbi = JsonAbi> {
 
     throw new FuelError(
       ErrorCode.FUNCTION_NOT_FOUND,
-      `function ${nameOrSignatureOrSelector} not found: ${JSON.stringify(fn)}.`
+      `Function ${nameOrSignatureOrSelector} not found.`
     );
   }
 
@@ -71,7 +71,7 @@ export class Interface<TAbi extends JsonAbi = JsonAbi> {
     const fragment =
       typeof functionFragment === 'string' ? this.getFunction(functionFragment) : functionFragment;
 
-    return fragment.decodeOutput(data);
+    return fragment.decodeOutput(data)[0];
   }
 
   decodeLog(data: BytesLike, logId: string): any {
@@ -85,7 +85,7 @@ export class Interface<TAbi extends JsonAbi = JsonAbi> {
 
     return AbiCoder.decode(this.jsonAbi, loggedType.loggedType, arrayify(data), 0, {
       encoding: this.encoding,
-    });
+    })[0];
   }
 
   encodeConfigurable(name: string, value: InputValue) {

packages/abi-coder/test/Interface.test.ts

@@ -1,6 +1,8 @@
 /* eslint-disable @typescript-eslint/no-explicit-any */
+import { ErrorCode, FuelError } from '@fuel-ts/errors';
+import { expectToThrowFuelError } from '@fuel-ts/errors/test-utils';
 import type { BN } from '@fuel-ts/math';
-import { concat } from '@fuel-ts/utils';
+import { concat, hexlify } from '@fuel-ts/utils';
 
 import { Interface } from '../src';
 /** @knipignore */
@@ -766,4 +768,57 @@ describe('Abi interface', () => {
       );
     });
   });
+
+  describe('decodeLog', () => {
+    it('should return decoded log by id', () => {
+      const data = exhaustiveExamplesInterface.decodeLog(
+        hexlify(Uint8Array.from([1, 0, 0, 0, 32])),
+        '8500535089865083573'
+      );
+      expect(data).toEqual({
+        a: true,
+        b: 32,
+      });
+    });
+
+    it('should throw an error when log does not exist', async () => {
+      await expectToThrowFuelError(
+        () => {
+          exhaustiveExamplesInterface.decodeLog(
+            hexlify(Uint8Array.from([1, 0, 0, 0, 32])),
+            '8500535089865083573'
+          );
+        },
+        new FuelError(
+          ErrorCode.LOG_TYPE_NOT_FOUND,
+          `Log type with logId '8500535089865083573' doesn't exist in the ABI.`
+        )
+      );
+    });
+  });
+
+  describe('decodeFunctionResult', () => {
+    it('should return decoded function result', () => {
+      const data = exhaustiveExamplesInterface.decodeFunctionResult(
+        'struct_simple',
+        hexlify(Uint8Array.from([1, 0, 0, 0, 32]))
+      );
+      expect(data).toEqual({
+        a: true,
+        b: 32,
+      });
+    });
+
+    it('should throw an error when function does not exist', async () => {
+      await expectToThrowFuelError(
+        () => {
+          exhaustiveExamplesInterface.decodeFunctionResult(
+            'doesnt_exist',
+            hexlify(Uint8Array.from([1, 0, 0, 0, 32]))
+          );
+        },
+        new FuelError(ErrorCode.FUNCTION_NOT_FOUND, `Function doesnt_exist not found.`)
+      );
+    });
+  });
 });

packages/abi-coder/test/fixtures/forc-projects/exhaustive-examples/src/main.sw

@@ -181,6 +181,8 @@ abi MyContract {
         arg3: (str[5], bool),
         arg4: MyOtherStruct,
     );
+
+    fn log();
 }
 
 impl MyContract for Contract {
@@ -339,4 +341,11 @@ impl MyContract for Contract {
     fn simple_vector(arg: Vec<u8>) -> Vec<u8> {
         arg
     }
+
+    fn log() {
+        log(SimpleStruct {
+            a: true,
+            b: 32u32,
+        });
+    }
 }

packages/account/src/providers/transaction-response/getDecodedLogs.ts

@@ -35,7 +35,7 @@ export function getDecodedLogs<T = unknown>(
           ? new BigNumberCoder('u64').encode(receipt.val0)
           : receipt.data;
 
-      const [decodedLog] = interfaceToUse.decodeLog(data, receipt.val1.toString());
+      const decodedLog = interfaceToUse.decodeLog(data, receipt.val1.toString());
       logs.push(decodedLog);
     }