Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: auto-loading storage slots based on ABI filepath #1346

Merged
merged 12 commits into from
Oct 17, 2023
Merged

feat: auto-loading storage slots based on ABI filepath #1346

merged 12 commits into from
Oct 17, 2023

Conversation

arboleya
Copy link
Member

Close #1233

@arboleya arboleya self-assigned this Oct 13, 2023
@arboleya arboleya changed the title feat: auto-loading *-storage_slots.json based on *-abi.json filepaths feat: auto-loading storage slots ABI filepath Oct 13, 2023
@arboleya arboleya changed the title feat: auto-loading storage slots ABI filepath feat: auto-loading storage slots based on ABI filepath Oct 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
84.94% (+0.06% 🔼)
 5306/6247
🟡 Branches
66.72% (+0.12% 🔼)
 774/1160
🟡 Functions
74.32% (+0.07% 🔼)
 871/1172
🟢 Lines
84.99% (+0.06% 🔼)
 5072/5968
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / collectStorageSlotsFilePaths.ts
 100% 100% 100% 100%

Test suite run success

1268 tests passing in 223 suites.

Report generated by 🧪jest coverage report action from 2fed420

@arboleya arboleya marked this pull request as ready for review October 13, 2023 13:47
camsjams
camsjams previously approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@camsjams camsjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

danielbate
danielbate previously approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, one comment re documentation flow but happy for you to decide 👍🏻

apps/docs/src/guide/contracts/storage-slots.md Show resolved Hide resolved
Torres-ssf
Torres-ssf previously approved these changes Oct 16, 2023
View reviewed changes
Torres-ssf
Torres-ssf previously approved these changes Oct 17, 2023
View reviewed changes
@arboleya arboleya merged commit a62c4b1 into master Oct 17, 2023
7 checks passed
@arboleya arboleya deleted the aa/feat/autoload-storage-slots branch October 17, 2023 18:10
@github-actions github-actions bot mentioned this pull request Oct 17, 2023
Merged
@Dhaiwat10 Dhaiwat10 mentioned this pull request Nov 30, 2023
Closed
@maschad maschad mentioned this pull request Sep 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@camsjams camsjams Awaiting requested review from camsjams

Assignees

@arboleya arboleya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-load storage slots when deploying contracts
5 participants
@arboleya @camsjams @danielbate @Torres-ssf @Dhaiwat10