Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add typegen and docs for RawSlice, Bytes, and StdString #1342

Merged
merged 25 commits into from
Oct 13, 2023
Merged

feat: add typegen and docs for RawSlice, Bytes, and StdString #1342

merged 25 commits into from
Oct 13, 2023

Conversation

camsjams
Copy link
Contributor

Closes #1334

@camsjams camsjams self-assigned this Oct 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
84.86% (+0.07% 🔼)
 5262/6201
🟡 Branches 66.75% 771/1155
🟡 Functions
74.29% (+0.13% 🔼)
 864/1163
🟢 Lines
84.92% (+0.08% 🔼)
 5034/5928
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / BytesType.ts
 100% 100% 100% 100%
🟢
... / RawUntypedSlice.ts
 100% 100% 100% 100%
🟢
... / StdStringType.ts
 100% 100% 100% 100%

Test suite run success

1267 tests passing in 222 suites.

Report generated by 🧪jest coverage report action from be21f19

arboleya
arboleya previously approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

apps/docs/src/guide/types/bytes.md Outdated Show resolved Hide resolved
apps/docs/src/guide/types/raw-slice.md Outdated Show resolved Hide resolved
danielbate
danielbate previously approved these changes Oct 13, 2023
View reviewed changes
Torres-ssf
Torres-ssf previously approved these changes Oct 13, 2023
View reviewed changes
Dhaiwat10
Dhaiwat10 previously approved these changes Oct 13, 2023
View reviewed changes
@camsjams camsjams enabled auto-merge (squash) October 13, 2023 15:38
Cameron Manavian and others added 2 commits October 13, 2023 08:39
digorithm
digorithm approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@camsjams camsjams merged commit f6fb12b into master Oct 13, 2023
7 checks passed
@camsjams camsjams deleted the cm/issue-1334 branch October 13, 2023 17:31
@github-actions github-actions bot mentioned this pull request Oct 13, 2023
Merged
@danielbate danielbate mentioned this pull request Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm digorithm approved these changes

@arboleya arboleya arboleya approved these changes

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

Assignees

@camsjams camsjams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ABI typegen to support RawSlice, Bytes, and StdString
6 participants
@camsjams @arboleya @digorithm @danielbate @Torres-ssf @Dhaiwat10