Rewrite fuel_asm::impl_instructions! to a proc macro #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
MitchTurner
reviewed
Aug 22, 2024
fuel-derive/src/asm.rs
Outdated
| let name = &arg.name; | ||
| if arg.is_imm() { | ||
| quote! { | ||
| packed_integer |= (#name.to_smallest_int() as u32); |
There was a problem hiding this comment.
Places like this would be better with a single-use helper function.
There was a problem hiding this comment.
Moved most of these to smaller functions.
netrome
previously approved these changes
Aug 26, 2024
xgreenx
reviewed
Aug 26, 2024
fuel-derive/src/asm.rs
Outdated
| .0 | ||
| .iter() | ||
| .map( | ||
| |Instruction { |
There was a problem hiding this comment.
It would be nice for each closure that we use inside of the map to have a named function like make_constructor_for_opcode. Name is up to you=)
There was a problem hiding this comment.
I've simplified the code quite a bit and each map has only a small block of code inside. Let me know if you still feel we need to have the closures as separate functions as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin. No exteranal functional changes, just refactoring.
Crate-internal
test_constructfunction has been removed, as the associated test didn't seem to catch any errors. It has been rewritten to use a fuzzing-style property-based testing.The purpose of this PR is to allow more complex instruction definitions in the future. This should allow moving some validity checks to instruction parsing level, and to improve type safety.
Checklist
Before requesting review