Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DA compression for fuel-tx types #670
DA compression for fuel-tx types #670
Changes from all commits
eddf4cb
bf61b73
1b0917e
0c7f3dd
cbc2173
82b2efa
1e792e9
6ad66c3
cc1b7a8
8f60962
3169f6c
ac811f5
8ed0672
f04df70
141efe5
da7819f
42e8634
781fe1e
546dda0
bf2b976
880d13c
b23bff5
293f0f0
a1b5174
dd40e5b
f7d6ced
21b4ab6
4188f37
f0be2b1
0b8a0d9
69ac157
1ef6803
07391b2
6b359f0
3ee7589
1530755
f1e7114
31083c1
0cc0be0
2a7904a
b2861d7
4f7a2d6
c984fa1
b947dae
5d9087d
3d2af6d
19aa0c0
9a80b08
af39dcf
bf75dbc
cc1b892
b8011ce
34c7a23
0342ae1
285cf88
b3e0718
ee39490
7aa5405
1bb7090
d23d6cd
efd2dc6
92983a9
7b88695
b60e38a
89654f1
d9c3aa3
7a98ae4
7e6a865
9b33143
cc61e1e
0fe904a
5728192
6356189
860dc98
987fdbb
90c71df
e80ee5d
cbe48f9
b0f52dd
1601729
59ffbd5
476c898
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about renaming macros into
CompressibleBy
andDecompressibleBy
to show which traits are implemented?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the point in having the same name here. I dislike it since the names are confusing. When I see
#[derive(fuel_compression::Compress)]
I know this type can be compressed by some
fuel_compression
-related machinery. When I see#[derive(fuel_compression::CompressibleBy)]
I'm like compressible by what?
Compressible
might be an improvement.Also,
Compress
implements bothCompressible
andCompressibleBy
, and the define macros having the same names as the trait obfuscates this fact even more.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it is true. But
Compressible
is a super trait ofCompressibleBy
, so it is not so bad=D But I agree that it is hidden property of the macro that can be discovered only from the comment.But in the case of
DecompressibleBy
everything is clear=) The macro implements the same trait.But it is up to you, I will not push it futher=)