Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gas_price_service_v0): remove unused trait impl #2410

Merged
merged 1 commit into from
Oct 30, 2024
Merged

chore(gas_price_service_v0): remove unused trait impl #2410

merged 1 commit into from
Oct 30, 2024

Conversation

rymnc
Copy link
Member

@rymnc rymnc commented Oct 30, 2024 •
edited
Loading

Linked Issues/PRs

  • none

Description

RunnableService didn't need to be implemented for GasPriceServiceV0 even in the tests.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@rymnc rymnc added the tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable. label Oct 30, 2024
@rymnc rymnc self-assigned this Oct 30, 2024
@rymnc rymnc added the no changelog Skip the CI check of the changelog modification label Oct 30, 2024
@rymnc rymnc marked this pull request as ready for review October 30, 2024 10:40
@rymnc rymnc requested a review from a team October 30, 2024 10:40
netrome
netrome approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@netrome netrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rymnc rymnc merged commit ba304f3 into master Oct 30, 2024
52 of 57 checks passed
@rymnc rymnc deleted the fix/unused-trait-impl branch October 30, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netrome netrome netrome approved these changes

@MitchTurner MitchTurner MitchTurner approved these changes

@xgreenx xgreenx Awaiting requested review from xgreenx xgreenx is a code owner

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

Assignees

@rymnc rymnc

Labels
no changelog Skip the CI check of the changelog modification tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rymnc @MitchTurner @netrome