Updated all pagination queries to work with the Stream instead of Iterator
#2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
reviewed
Oct 14, 2024
2 tasks
xgreenx
added a commit
that referenced
this pull request
Oct 14, 2024
…Iterator` (#2341) Accidentally merged #2337. Reopen it again in this PR This change updates all pagination queries to work with the async stream instead of the sync iterator. It is preparation for the next PR to move the fetching of transactions, coins, and messages into a separate thread and await the return of the result from this thread. Also, this PR limits the maximum number of requested coins from the `coins_to_spend` query to `max_inputs`. ## Checklist - [x] Breaking changes are clearly marked as such in the PR description and changelog ### Before requesting review - [x] I have reviewed the code myself --------- Co-authored-by: Mårten Blankfors <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates all pagination queries to work with the async stream instead of the sync iterator.
It is preparation for the next PR to move the fetching of transactions, coins, and messages into a separate thread and await the return of the result from this thread.
Also, this PR limits the maximum number of requested coins from the
coins_to_spendquery tomax_inputs.Checklist
Before requesting review