Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(benches): conditional dropping of databases in benchmarks #2170

Merged
merged 5 commits into from
Sep 6, 2024
Merged

chore(benches): conditional dropping of databases in benchmarks #2170

merged 5 commits into from
Sep 6, 2024

Conversation

rymnc
Copy link
Member

@rymnc rymnc commented Sep 5, 2024

Note

This PR is 2/2 on the ShallowTempDir refactor

Linked Issues/PRs

Description

conditionally drops the benchmark databases if DB_CLEAN_UP is set to false.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • ] The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@rymnc rymnc added tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable. no changelog Skip the CI check of the changelog modification labels Sep 5, 2024
@rymnc rymnc self-assigned this Sep 5, 2024
@rymnc rymnc requested review from xgreenx and a team September 5, 2024 17:21
@rymnc rymnc marked this pull request as ready for review September 5, 2024 17:48
netrome
netrome previously approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@netrome netrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff! Just two questions. I'm not sure if it makes sense to emit log events within the destructor, but if there is an unexpected error it would be nice to gain some visibility into it.

benches/src/utils.rs Outdated Show resolved Hide resolved
benches/src/utils.rs Show resolved Hide resolved
@rymnc rymnc requested a review from netrome September 5, 2024 20:10
netrome
netrome previously approved these changes Sep 5, 2024
View reviewed changes
xgreenx
xgreenx previously approved these changes Sep 6, 2024
View reviewed changes
@rymnc rymnc dismissed stale reviews from xgreenx and netrome via e3b01b8 September 6, 2024 06:39
@rymnc rymnc enabled auto-merge (squash) September 6, 2024 06:39
@rymnc rymnc requested a review from xgreenx September 6, 2024 06:52
@rymnc rymnc merged commit 611bf7c into master Sep 6, 2024
31 checks passed
@rymnc rymnc deleted the chore/conditional-drop-db-bench branch September 6, 2024 06:56
@rymnc rymnc mentioned this pull request Sep 6, 2024
Merged
9 tasks
rymnc added a commit that referenced this pull request Sep 6, 2024
@rymnc
chore(shallow_temp_dir): panic if not panicking (#2172)
a952ff4 
## Linked Issues/PRs
<!-- List of related issues/PRs -->
- #2170

## Description
<!-- List of detailed changes -->
Panics while dropping the database if there is no pre-existing panic,
similar to how its done in stdlib :)

## Checklist
- [x] Breaking changes are clearly marked as such in the PR description
and changelog
- [x] New behavior is reflected in tests
- [x] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [x] I have reviewed the code myself
- [x] I have created follow-up issues caused by this PR and linked them
here

### After merging, notify other teams

[Add or remove entries as needed]

- [ ] [Rust SDK](https://github.com/FuelLabs/fuels-rs/)
- [ ] [Sway compiler](https://github.com/FuelLabs/sway/)
- [ ] [Platform
documentation](https://github.com/FuelLabs/devrel-requests/issues/new?assignees=&labels=new+request&projects=&template=NEW-REQUEST.yml&title=%5BRequest%5D%3A+)
(for out-of-organization contributors, the person merging the PR will do
this)
- [ ] Someone else?
@xgreenx xgreenx mentioned this pull request Sep 17, 2024
Merged
xgreenx added a commit that referenced this pull request Sep 18, 2024
@xgreenx
Release v0.36.0 (#2213)
b00bd0d 
## Version v0.36.0

### Added
- [2135](#2135): Added metrics
logging for number of blocks served over the p2p req/res protocol.
- [2151](#2151): Added
limitations on gas used during dry_run in API.
- [2188](#2188): Added the new
variant `V2` for the `ConsensusParameters` which contains the new
`block_transaction_size_limit` parameter.
- [2163](#2163): Added
runnable task for fetching block committer data.
- [2204](#2204): Added
`dnsaddr` resolution for TLD without suffixes.

### Changed

#### Breaking
- [2199](#2199): Applying
several breaking changes to the WASM interface from backlog:
- Get the module to execute WASM byte code from the storage first, an
fallback to the built-in version in the case of the
`FUEL_ALWAYS_USE_WASM`.
- Added `host_v1` with a new `peek_next_txs_size` method, that accepts
`tx_number_limit` and `size_limit`.
- Added new variant of the return type to pass the validation result. It
removes block serialization and deserialization and should improve
performance.
- Added a V1 execution result type that uses `JSONError` instead of
postcard serialized error. It adds flexibility of how variants of the
error can be managed. More information about it in
FuelLabs/fuel-vm#797. The change also moves
`TooManyOutputs` error to the top. It shows that `JSONError` works as
expected.
- [2145](#2145): feat:
Introduce time port in PoA service.
- [2155](#2155): Added trait
declaration for block committer data
- [2142](#2142): Added
benchmarks for varied forms of db lookups to assist in optimizations.
- [2158](#2158): Log the
public address of the signing key, if it is specified
- [2188](#2188): Upgraded the
`fuel-vm` to `0.57.0`. More information in the
[release](https://github.com/FuelLabs/fuel-vm/releases/tag/v0.57.0).

## What's Changed
* chore(p2p_service): add metrics for number of blocks requested over
p2p req/res protocol by @rymnc in
#2135
* Weekly `cargo update` by @github-actions in
#2149
* Debug V1 algorightm and use more realistic values in gas price
analysis by @MitchTurner in
#2129
* feat(gas_price_service): include trait declaration for block committer
data by @rymnc in #2155
* Convert gas price analysis tool to CLI by @MitchTurner in
#2156
* chore: add benchmarks for varied forms of lookups by @rymnc in
#2142
* Add label nochangelog on weekly cargo update by @AurelienFT in
#2152
* Log consensus-key signer address if specified by @acerone85 in
#2158
* chore(rocks_db): move ShallowTempDir to benches crate by @rymnc in
#2168
* chore(benches): conditional dropping of databases in benchmarks by
@rymnc in #2170
* feat: Introduce time port in PoA service by @netrome in
#2145
* Get DA costs from predefined data by @MitchTurner in
#2157
* chore(shallow_temp_dir): panic if not panicking by @rymnc in
#2172
* chore: Add initial CODEOWNERS file by @netrome in
#2179
* Weekly `cargo update` by @github-actions in
#2177
* fix(db_lookup_times): rework core logic of benchmark by @rymnc in
#2159
* Add verification on transaction dry_run that they don't spend more
than block gas limit by @AurelienFT in
#2151
* bug: fix algorithm overflow issues by @MitchTurner in
#2173
* feat(gas_price_service): create runnable task for expensive background
polling for da metadata by @rymnc in
#2163
* Weekly `cargo update` by @github-actions in
#2197
* Fix bug with gas price factor in V1 algorithm by @MitchTurner in
#2201
* Applying several breaking changes to the WASM interface from backlog
by @xgreenx in #2199
* chore(p2p): dnsaddr recursive resolution by @rymnc in
#2204

## New Contributors
* @acerone85 made their first contribution in
#2158

**Full Changelog**:
v0.35.0...v0.36.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netrome netrome netrome approved these changes

@xgreenx xgreenx xgreenx approved these changes

Assignees

@rymnc rymnc

Labels
no changelog Skip the CI check of the changelog modification tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rymnc @xgreenx @netrome