Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates to the documentation #2161

Closed
wants to merge 4 commits into from
Closed

Minor updates to the documentation #2161

wants to merge 4 commits into from

Conversation

rafal-ch
Copy link
Contributor

@rafal-ch rafal-ch commented Sep 4, 2024 •
edited
Loading

Description

This PR changes the following:

  1. Update the debugging.md file to refer to fuel-core-keygen instead of fuel-core-keygen-bin. This change stems from this modification.
  2. Minor typos that I stumbled upon when reading through the codebase

Before requesting review

  • I have reviewed the code myself

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rafal-ch rafal-ch added the no changelog Skip the CI check of the changelog modification label Sep 4, 2024
@rafal-ch rafal-ch marked this pull request as ready for review September 25, 2024 10:52
@rafal-ch rafal-ch requested a review from a team September 25, 2024 10:52
xgreenx
xgreenx previously approved these changes Sep 25, 2024
View reviewed changes
@rymnc
Copy link
Member

rymnc commented Sep 25, 2024

since this is a "renaming" PR, can we also include -

fuel-core/crates/fuel-core/src/database.rs

Line 124 in 5963a4e

pub type ReyalerIterableKeyValueView = IterableKeyValueView<ColumnType<Relayer>>;

please?

@rafal-ch
Copy link
Contributor Author

Closed in favor of #2250

This one has been created from my fork, hence there are CI issues.

@rafal-ch rafal-ch closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymnc rymnc rymnc approved these changes

@xgreenx xgreenx xgreenx left review comments

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner is a code owner

Assignees
No one assigned
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rafal-ch @CLAassistant @rymnc @xgreenx