Update default gas costs based on 0.35.0 benchmarks #2153

xgreenx · 2024-09-02T12:26:56Z

Closes #2049

Results from the benchmark with fuel-core 0.35.0. The gas cost decreased for all that somehow touched storage or balances because of optimization for SMT not to request siblings.

Checklist

Breaking changes are clearly marked as such in the PR description and changelog

- Added benchmarks for `bsiz` and `bldd` - Fixed some benchmarks by using original memory

…mrks # Conflicts: # Cargo.lock # bin/fuel-core/chainspec/local-testnet/state_transition_bytecode.wasm

netrome

Looks good to me, though there's still a lot I feel I cannot fully verify. One thing that stands out to me though is how much larger the benchmarks file has become. Is that due to the extra blobcode benchmarks?

benches/src/lib.rs

xgreenx · 2024-09-12T17:32:52Z

Looks good to me, though there's still a lot I feel I cannot fully verify. One thing that stands out to me though is how much larger the benchmarks file has become. Is that due to the extra blobcode benchmarks?

Github just shows it incorrectly=) If you open removed file, you can see that this file had the same number of lines(almost)

Co-authored-by: Mårten Blankfors <[email protected]>

…mrks # Conflicts: # bin/fuel-core/chainspec/local-testnet/state_transition_bytecode.wasm

netrome · 2024-09-12T18:01:58Z

Looks good to me, though there's still a lot I feel I cannot fully verify. One thing that stands out to me though is how much larger the benchmarks file has become. Is that due to the extra blobcode benchmarks?

Github just shows it incorrectly=) If you open removed file, you can see that this file had the same number of lines(almost)

Ah interesting. Thanks for the clarification! 🙏

…mrks # Conflicts: # CHANGELOG.md # bin/fuel-core/chainspec/local-testnet/state_transition_bytecode.wasm

…rks' into feature/fuel-core-0.35.0-benchamrks

MitchTurner

LGTM. Just some quick questions to understand everything that happened with this PR.

MitchTurner · 2024-09-19T08:14:18Z

benches/benches/vm_set/blockchain.rs

@@ -441,6 +483,33 @@ pub fn run(c: &mut Criterion) {

    csiz.finish();

+    let mut bsiz = c.benchmark_group("bsiz");


How were we getting the values for bldd and bsiz before? It looks like they didn't exist before.

We had a task to add benchamrks for these upcodes: #2049

Before we just copied values from similar contract opcodes

MitchTurner · 2024-09-19T08:14:49Z

benches/benches/vm_set/mem.rs

@@ -77,7 +86,8 @@ pub fn run(c: &mut Criterion) {
        cfei_linear.push(1_000_000);
        cfei_linear.push(10_000_000);
        for i in cfei_linear {
-            let bench = VmBench::new(op::cfei(i as u32));
+            let memory = MemoryInstance::from(vec![123; MEM_SIZE]);
+            let bench = VmBench::new(op::cfei(i as u32)).with_memory(memory);


Why did we need the memory added here?/Why didn't we have it before?

I just added it to remove any potential optimizations related to zeroed memory. Now all benchmarks use non zeroed memory

rafal-ch

LGTM 👍

However, it's not clear for me how exactly the numbers in GasCostsValuesV4::default_gas_costs() were calculated.

benches/src/bin/collect.rs

benches/benches/vm_set/mem.rs

@rymnc

## Version v0.37.0 ### Added - [1609](#1609): Add DA compression support. Compressed blocks are stored in the offchain database when blocks are produced, and can be fetched using the GraphQL API. - [2290](#2290): Added a new CLI argument `--graphql-max-directives`. The default value is `10`. - [2195](#2195): Added enforcement of the limit on the size of the L2 transactions per block according to the `block_transaction_size_limit` parameter. - [2131](#2131): Add flow in TxPool in order to ask to newly connected peers to share their transaction pool - [2182](#2151): Limit number of transactions that can be fetched via TxSource::next - [2189](#2151): Select next DA height to never include more than u16::MAX -1 transactions from L1. - [2162](#2162): Pool structure with dependencies, etc.. for the next transaction pool module. Also adds insertion/verification process in PoolV2 and tests refactoring - [2265](#2265): Integrate Block Committer API for DA Block Costs. - [2280](#2280): Allow comma separated relayer addresses in cli - [2299](#2299): Support blobs in the predicates. - [2300](#2300): Added new function to `fuel-core-client` for checking whether a blob exists. ### Changed #### Breaking - [2299](#2299): Anyone who wants to participate in the transaction broadcasting via p2p must upgrade to support new predicates on the TxPool level. - [2299](#2299): Upgraded `fuel-vm` to `0.58.0`. More information in the [release](https://github.com/FuelLabs/fuel-vm/releases/tag/v0.58.0). - [2276](#2276): Changed how complexity for blocks is calculated. The default complexity now is 80_000. All queries that somehow touch the block header now are more expensive. - [2290](#2290): Added a new GraphQL limit on number of `directives`. The default value is `10`. - [2206](#2206): Use timestamp of last block when dry running transactions. - [2153](#2153): Updated default gas costs for the local testnet configuration to match `fuel-core 0.35.0`. ## What's Changed * fix: use core-test.fuellabs.net for dnsaddr resolution by @rymnc in #2214 * Removed state transition bytecode from the local testnet by @xgreenx in #2215 * Send whole transaction pool upon subscription to gossip by @AurelienFT in #2131 * Update default gas costs based on 0.35.0 benchmarks by @xgreenx in #2153 * feat: Use timestamp of last block when dry running transactions by @netrome in #2206 * fix(dnsaddr_resolution): use fqdn separator to prevent suffixing by dns resolvers by @rymnc in #2222 * TransactionSource: specify maximum number of transactions to be fetched by @acerone85 in #2182 * Implement worst case scenario for price algorithm v1 by @rafal-ch in #2219 * chore(gas_price_service): define port for L2 data by @rymnc in #2224 * Block producer selects da height to never exceed u64::MAX - 1 transactions from L1 by @acerone85 in #2189 * Weekly `cargo update` by @github-actions in #2236 * Use fees to calculate DA reward and avoid issues with Gwei/Wei conversions by @MitchTurner in #2229 * Protect against passing `i128::MIN` to `abs()` which causes overflow by @rafal-ch in #2241 * Acquire `da_finalization_period` from the command line by @rafal-ch in #2240 * Executor: test Tx_count limit with incorrect tx source by @acerone85 in #2242 * Minor updates to docs + a few typos fixed by @rafal-ch in #2250 * chore(gas_price_service): move algorithm_updater to fuel-core-gas-price-service by @rymnc in #2246 * Use single heavy input in the `transaction_throughput.rs` benchmarks by @xgreenx in #2205 * Enforce the block size limit by @rafal-ch in #2195 * feat: build ARM and AMD in parallel by @mchristopher in #2130 * Weekly `cargo update` by @github-actions in #2268 * chore(gas_price_service): split into v0 and v1 and squash FuelGasPriceUpdater type into GasPriceService by @rymnc in #2256 * feat(gas_price_service): update block committer da source with established contract by @rymnc in #2265 * Use bytes from `unrecorded_blocks` rather from the block from DA by @MitchTurner in #2252 * TxPool v2 General architecture by @AurelienFT in #2162 * Add value delimiter and tests args by @AurelienFT in #2280 * fix(da_block_costs): remove Arc<Mutex<>> on shared_state and expose channel by @rymnc in #2278 * fix(combined_database): syncing auxiliary databases on startup with custom behaviour by @rymnc in #2272 * fix: Manually encode Authorization header for eventsource_client by @Br1ght0ne in #2284 * Address `async-graphql` vulnerability by @MitchTurner in #2290 * Update the WASM compatibility tests for `0.36` release by @rafal-ch in #2271 * DA compression by @Dentosal in #1609 * Use different port for every version compatibility test by @rafal-ch in #2301 * Fix block query complexity by @xgreenx in #2297 * Support blobs in predicates by @Voxelot in #2299 **Full Changelog**: v0.36.0...v0.37.0

xgreenx added 2 commits August 28, 2024 15:01

Release v0.35.0

b8397fe

New gas prices with fuel-core 0.35.0 benchmarks

a5eb66d

- Added benchmarks for `bsiz` and `bldd` - Fixed some benchmarks by using original memory

xgreenx self-assigned this Sep 2, 2024

xgreenx added 4 commits September 10, 2024 19:50

Updated chain config

03016f4

Merge branch 'refs/heads/master' into feature/fuel-core-0.35.0-bencha…

563bc2f

…mrks # Conflicts: # Cargo.lock # bin/fuel-core/chainspec/local-testnet/state_transition_bytecode.wasm

Merge with master

b30a0df

Updated CHANGELOG.md

3dcbdb1

xgreenx marked this pull request as ready for review September 10, 2024 18:04

xgreenx requested review from Dentosal and MitchTurner as code owners September 10, 2024 18:04

xgreenx changed the title ~~Feature/fuel core 0.35.0 benchamrks~~ Update default gas costs based on 0.35.0 benchmarks Sep 10, 2024

xgreenx requested a review from a team September 11, 2024 11:44

netrome previously approved these changes Sep 11, 2024

View reviewed changes

benches/src/lib.rs Outdated Show resolved Hide resolved

Update benches/src/lib.rs

8ac1599

Co-authored-by: Mårten Blankfors <[email protected]>

xgreenx dismissed netrome’s stale review via 8ac1599 September 12, 2024 17:33

xgreenx added 3 commits September 12, 2024 19:34

Merge branch 'refs/heads/master' into feature/fuel-core-0.35.0-bencha…

cd0f5ab

…mrks # Conflicts: # bin/fuel-core/chainspec/local-testnet/state_transition_bytecode.wasm

Fix CI

a26d6cd

Merge bytecode

e9e2cdd

netrome previously approved these changes Sep 12, 2024

View reviewed changes

xgreenx and others added 3 commits September 13, 2024 15:58

Merge branch 'master' into feature/fuel-core-0.35.0-benchamrks

f192066

Merge branch 'master' into feature/fuel-core-0.35.0-benchamrks

1562de8

Merge branch 'refs/heads/master' into feature/fuel-core-0.35.0-bencha…

71beb30

…mrks # Conflicts: # CHANGELOG.md # bin/fuel-core/chainspec/local-testnet/state_transition_bytecode.wasm

xgreenx dismissed netrome’s stale review via 71beb30 September 18, 2024 07:36

xgreenx enabled auto-merge (squash) September 18, 2024 07:36

xgreenx requested review from netrome and a team September 18, 2024 07:37

netrome previously approved these changes Sep 18, 2024

View reviewed changes

Merge branch 'master' into feature/fuel-core-0.35.0-benchamrks

b95a57d

Merge branch 'master' into feature/fuel-core-0.35.0-benchamrks

91b1d9d

xgreenx dismissed netrome’s stale review via 91b1d9d September 19, 2024 08:03

xgreenx requested review from netrome and a team September 19, 2024 08:03

xgreenx added 2 commits September 19, 2024 10:10

Use without formating

4bf2af6

Merge remote-tracking branch 'origin/feature/fuel-core-0.35.0-bencham…

5671ad0

…rks' into feature/fuel-core-0.35.0-benchamrks

MitchTurner reviewed Sep 19, 2024

View reviewed changes

rafal-ch previously approved these changes Sep 19, 2024

View reviewed changes

benches/src/bin/collect.rs Show resolved Hide resolved

benches/benches/vm_set/mem.rs Show resolved Hide resolved

Apply suggestion

87dc4c9

xgreenx dismissed rafal-ch’s stale review via 87dc4c9 September 19, 2024 08:33

MitchTurner approved these changes Sep 19, 2024

View reviewed changes

rafal-ch approved these changes Sep 19, 2024

View reviewed changes

xgreenx merged commit 525c48f into master Sep 19, 2024
31 checks passed

xgreenx deleted the feature/fuel-core-0.35.0-benchamrks branch September 19, 2024 08:57

xgreenx mentioned this pull request Oct 5, 2024

Release v0.37.0 #2302

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update default gas costs based on 0.35.0 benchmarks #2153

Update default gas costs based on 0.35.0 benchmarks #2153

xgreenx commented Sep 2, 2024 •

edited

Loading

netrome left a comment

xgreenx commented Sep 12, 2024

netrome commented Sep 12, 2024

MitchTurner left a comment

MitchTurner Sep 19, 2024

xgreenx Sep 19, 2024

MitchTurner Sep 19, 2024

xgreenx Sep 19, 2024

rafal-ch left a comment

		@@ -441,6 +483,33 @@ pub fn run(c: &mut Criterion) {

		csiz.finish();

		let mut bsiz = c.benchmark_group("bsiz");

Update default gas costs based on 0.35.0 benchmarks #2153

Update default gas costs based on 0.35.0 benchmarks #2153

Conversation

xgreenx commented Sep 2, 2024 • edited Loading

Checklist

netrome left a comment

Choose a reason for hiding this comment

xgreenx commented Sep 12, 2024

netrome commented Sep 12, 2024

MitchTurner left a comment

Choose a reason for hiding this comment

MitchTurner Sep 19, 2024

Choose a reason for hiding this comment

xgreenx Sep 19, 2024

Choose a reason for hiding this comment

MitchTurner Sep 19, 2024

Choose a reason for hiding this comment

xgreenx Sep 19, 2024

Choose a reason for hiding this comment

rafal-ch left a comment

Choose a reason for hiding this comment

xgreenx commented Sep 2, 2024 •

edited

Loading