add metrics to services #1267
Closed
add metrics to services #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgreenx
reviewed
Aug 3, 2023
| @@ -180,6 +182,8 @@ where | |||
| D: P2pDb + 'static, | |||
| { | |||
| async fn run(&mut self, watcher: &mut StateWatcher) -> anyhow::Result<bool> { | |||
| let start = Instant::now(); | |||
There was a problem hiding this comment.
Is that possible to move it to ServiceRunner and have it for each service?
| @@ -53,6 +60,8 @@ impl SyncHeights { | |||
| /// Sync the state from the height stream. | |||
| /// This stream never blocks or errors. | |||
| pub(crate) async fn sync(&mut self) -> Option<()> { | |||
| let start = ServiceMetrics::instant(); | |||
There was a problem hiding this comment.
It measures busy and idle time together, we want to know about both independently.
| self.import_inner(shutdown).await?; | ||
|
|
||
| IMPORT_METRICS.observe(start); |
There was a problem hiding this comment.
Each service may have the instance inside of ServiceRunner and you don't need to use lazy=)
|
Clsoe in favor of #1284 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1168
I added metrics to each
run()method ofRunnableTaskimplementor.Improvement: this could be hidden behind
metricsfeature?