-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add recover public key from message and signature #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this functionality is already implemented in the forc-crypto
plugin. @crodas Can you confirm?
That is not implemented @sdankel but it can be added. I can port over this PR to |
I think it would make sense to move it to forc-crypto and keep the wallet cli focussed on transfers and signatures etc. |
This function is ported from FuelLabs/forc-wallet#152
Closed in favour of FuelLabs/sway#5419 |
This function is ported from FuelLabs/forc-wallet#152
This function is ported from FuelLabs/forc-wallet#152
This function is ported from FuelLabs/forc-wallet#152
This function is ported from FuelLabs/forc-wallet#152
## Description Add recover-public-key to forc-crypto This function is ported from FuelLabs/forc-wallet#152 This PR depends on #5388 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
ref #92