Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add recover public key from message and signature #152

Closed
wants to merge 1 commit into from

Conversation

quidproquoo
Copy link

ref #92

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2023

CLA assistant check
All committers have signed the CLA.

@kayagokalp kayagokalp added the enhancement New feature or request label Dec 7, 2023
@kayagokalp kayagokalp requested a review from a team December 7, 2023 19:20
Copy link
Member

@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this functionality is already implemented in the forc-crypto plugin. @crodas Can you confirm?

@crodas
Copy link
Contributor

crodas commented Dec 12, 2023

That is not implemented @sdankel but it can be added. I can port over this PR to forc crypto (which is responsible for address conversion, hashing and private key to public key)

@kayagokalp
Copy link
Member

I think it would make sense to move it to forc-crypto and keep the wallet cli focussed on transfers and signatures etc.

crodas added a commit to FuelLabs/sway that referenced this pull request Dec 21, 2023
@crodas crodas mentioned this pull request Dec 21, 2023
7 tasks
@crodas
Copy link
Contributor

crodas commented Dec 21, 2023

Closed in favour of FuelLabs/sway#5419

@crodas crodas closed this Dec 21, 2023
crodas added a commit to FuelLabs/sway that referenced this pull request Dec 21, 2023
crodas added a commit to FuelLabs/sway that referenced this pull request Jan 10, 2024
crodas added a commit to FuelLabs/sway that referenced this pull request Jan 16, 2024
crodas added a commit to FuelLabs/sway that referenced this pull request Jan 17, 2024
crodas added a commit to FuelLabs/sway that referenced this pull request Jan 23, 2024
## Description

Add recover-public-key to forc-crypto

This function is ported from
FuelLabs/forc-wallet#152

This PR depends on #5388

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants