Changed default for SaveChanges during dispose to "false"

FubarDevelopment · Dec 17, 2021 · 59ea64d · 59ea64d
1 parent 3482a74
commit 59ea64d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/FubarDev.UnitOfWork.Tests/NonTransactionalTests.cs b/FubarDev.UnitOfWork.Tests/NonTransactionalTests.cs
@@ -3,6 +3,7 @@
 // </copyright>
 
 using System;
+using System.Linq;
 using System.Threading.Tasks;
 
 using FubarDev.UnitOfWork.Tests.Support;
@@ -58,7 +59,7 @@ public async Task TestDisposeAsync()
             }
 
             Assert.Contains(repositoryId, _repositoryManager.Creations);
-            Assert.Equal(1, _repositoryManager.SavedChangesCount);
+            Assert.Equal(0, _repositoryManager.SavedChangesCount);
             Assert.Equal(1, _repositoryManager.DisposedRepositories);
         }
 
@@ -77,7 +78,7 @@ public async Task TestNestedAsync()
 
             Assert.Equal(repositoryId1, repositoryId2);
             Assert.Equal(repositoryId1, Assert.Single(_repositoryManager.Creations));
-            Assert.Equal(2, _repositoryManager.SavedChangesCount);
+            Assert.Equal(0, _repositoryManager.SavedChangesCount);
             Assert.Equal(1, _repositoryManager.DisposedRepositories);
         }
     }

diff --git a/FubarDev.UnitOfWork.Tests/TransactionalTests.cs b/FubarDev.UnitOfWork.Tests/TransactionalTests.cs
@@ -167,7 +167,7 @@ public async Task TestNestedWithNonTransactionalAsync()
 
             Assert.Equal(repositoryId1, repositoryId2);
             Assert.Equal(repositoryId1, Assert.Single(_repositoryManager.Creations));
-            Assert.Equal(1, _repositoryManager.SavedChangesCount);
+            Assert.Equal(0, _repositoryManager.SavedChangesCount);
             Assert.Contains(repositoryId1, _repositoryManager.Commits);
             Assert.Contains(repositoryId1, _repositoryManager.Rollbacks);
             Assert.Equal(0, _repositoryManager.CommitCount);
@@ -196,7 +196,7 @@ public async Task TestNestedWithNonTransactionalInWrongOrderAsync()
 
             Assert.Equal(repositoryId1, repositoryId2);
             Assert.Equal(repositoryId1, Assert.Single(_repositoryManager.Creations));
-            Assert.Equal(1, _repositoryManager.SavedChangesCount);
+            Assert.Equal(0, _repositoryManager.SavedChangesCount);
             Assert.Contains(repositoryId1, _repositoryManager.Commits);
             Assert.Contains(repositoryId1, _repositoryManager.Rollbacks);
             Assert.Equal(0, _repositoryManager.CommitCount);

diff --git a/FubarDev.UnitOfWork/UnitOfWorkFactory.cs b/FubarDev.UnitOfWork/UnitOfWorkFactory.cs
@@ -44,7 +44,7 @@ public UnitOfWorkFactory(
             IOptions<UnitOfWorkFactoryOptions>? options = null)
         {
             _allowNestedTransactions = options?.Value.AllowNestedTransactions ?? false;
-            _saveChangesOnDispose = options?.Value.SaveChangesWhenDisposingUnitOfWork ?? true;
+            _saveChangesOnDispose = options?.Value.SaveChangesWhenDisposingUnitOfWork ?? false;
             _repositoryManager = repositoryManager;
             _logger = logger;
             _statusManager = new DefaultStatusManager<UnitOfWorkStatusItem<TRepository>>(