Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FtpServerBuilderExtensionsForChecks.cs IFtpConnectionCheck #148

Open
alexandrius007 opened this issue Oct 7, 2022 · 1 comment
Open

FtpServerBuilderExtensionsForChecks.cs IFtpConnectionCheck #148

alexandrius007 opened this issue Oct 7, 2022 · 1 comment
Assignees
@fubar-coder
Labels
bug

Comments

@alexandrius007
Copy link

I think this IFtpConnectionCheck should be scoped in FtpServerBuilderExtensionsForChecks.cs:

builder.Services.AddScoped<IFtpConnectionCheck, FtpConnectionIdleCheck>() not singelton

if this class is singelton for all connections will be the same idle time.
alexandrius007 pushed a commit to alexandrius007/FtpServer that referenced this issue Oct 10, 2022
FubarDevelopment#147 fix Collection was modified;
4c8cf6f 
FubarDevelopment#148 fix idle constructor
@fubar-coder fubar-coder self-assigned this Oct 10, 2022
@fubar-coder
Copy link
Contributor

It seems that you're right. I'll look into it.

@Titonus Titonus mentioned this issue Feb 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fubar-coder fubar-coder

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fubar-coder @alexandrius007