-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: focus trap #1679
fix: focus trap #1679
Conversation
bojangles-m
commented
Dec 13, 2023
- updated focus trap
- removed close modal onBlur
- removed content of non active tab item
✅ Deploy Preview for beta-fondue-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Everything works as expected! 🎉
It also works nice with the new usage 😄 . I just need to dedicate a bit of time to make it work when Portal is enabled to change it to an element listener instead of window.
Thnx @imoutaharik for great collaboration 👍 |
Lead time: 18 hours, 45 minutes, 19 seconds (18.76 total hours) from first commit to close.
|
🎉 This PR is included in version 12.0.0-beta.390 🎉 The release is available on: Your semantic-release bot 📦🚀 |