Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: focus trap #1679

Merged
merged 5 commits into from
Dec 14, 2023
Merged

fix: focus trap #1679

merged 5 commits into from
Dec 14, 2023

Conversation

bojangles-m
Copy link
Contributor

  • updated focus trap
  • removed close modal onBlur
  • removed content of non active tab item

Copy link

netlify bot commented Dec 13, 2023

Deploy Preview for beta-fondue-components ready!

Name Link
🔨 Latest commit ebd6c00
🔍 Latest deploy log https://app.netlify.com/sites/beta-fondue-components/deploys/657ade4b77b7d3000821c631
😎 Deploy Preview https://deploy-preview-1679--beta-fondue-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bojangles-m bojangles-m self-assigned this Dec 13, 2023
Copy link
Contributor

@imoutaharik imoutaharik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Everything works as expected! 🎉
It also works nice with the new usage 😄 . I just need to dedicate a bit of time to make it work when Portal is enabled to change it to an element listener instead of window.

@bojangles-m
Copy link
Contributor Author

Thanks! Everything works as expected! 🎉 It also works nice with the new usage 😄 . I just need to dedicate a bit of time to make it work when Portal is enabled to change it to an element listener instead of window.

Thnx @imoutaharik for great collaboration 👍

@bojangles-m bojangles-m merged commit 6b53c4a into beta Dec 14, 2023
15 checks passed
@bojangles-m bojangles-m deleted the fix/focus-trap branch December 14, 2023 13:44
Copy link
Contributor

Lead time: 18 hours, 45 minutes, 19 seconds (18.76 total hours) from first commit to close.
Review time: 18 hours, 43 minutes, 38 seconds (18.73 total hours) from ready for review to close.

  • First commit: 13.12.2023, 19:59:02.
  • Ready for review: 13.12.2023, 20:00:43.
  • Closed: 14.12.2023, 14:44:21.

Copy link
Contributor

🎉 This PR is included in version 12.0.0-beta.390 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants