Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong calculation of top spacer size #735

Closed
webian opened this issue Oct 25, 2023 · 0 comments · Fixed by #736
Closed

Wrong calculation of top spacer size #735

webian opened this issue Oct 25, 2023 · 0 comments · Fixed by #736

Comments

@webian
Copy link
Collaborator

webian commented Oct 25, 2023

frontend_editing/Resources/Public/JavaScript/Editor.js

Line 104 in fe7306b

const toolbarTopYPosition = window.pageYOffset + firstInlineActionsToolbar.getBoundingClientRect().top;
calculates toolbarTopYPosition using window.pageYOffset that is always 0 because window is the iFrame containing the FE not the FE itself. When the page is scrolled down and then refreshed, the top spacer is added wrongly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Use contentWindow to calculate top spacer webian/frontend_editing
1 participant
@webian