Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline editing wrappers appearance problem #486

Open
Messj1 opened this issue Feb 24, 2021 · 2 comments
Open

inline editing wrappers appearance problem #486

Messj1 opened this issue Feb 24, 2021 · 2 comments

Comments

@Messj1
Copy link
Contributor

Messj1 commented Feb 24, 2021

There is a small UI bug since it truly can break the flow.

Originally posted by @erredeco in #270 (comment)

... it changes the appearance of the page...

So we have to avoid:

  1. inline action and content wrapper
  2. inline "block" editor wrapper

As example we could move (copy) the content with javascript and append after the wrapper:

<div style="content: none;" class="cke_editable cke_editable_inline">
  <p>...</p>
  <p>...</p>
</div>
<p data-cid="some-uid">...</p>
<p data-cid="some-uid">...</p>

Or we can move the inline-action wrapper inside the content layout with an new ViewHelper:

<div id="c1" class="frame frame-default frame-type-text frame-layout-0">
  <div class="t3-frontend-editing__ce>
    <span class="t3-frontend-editing__inline-actions">...</span>
  </div>
...
</div>

This would prevent design problems, since the integrator can decide were it should appear.

Any opinions?

@MattiasNilsson
Copy link
Contributor

@Messj1 This sounds like an awesome idea, go for it!

@vaxul
Copy link
Contributor

vaxul commented May 17, 2021

@Messj1 maybe you would like to add an opinion to #537?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants