Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing header-fields vs. headers in Text-field #270

Open
pxamike opened this issue Dec 12, 2017 · 3 comments
Open

Editing header-fields vs. headers in Text-field #270

pxamike opened this issue Dec 12, 2017 · 3 comments
Labels
documentation Add to documentation wontfix

Comments

@pxamike
Copy link
Collaborator

pxamike commented Dec 12, 2017

selection_086

The screenshot shows a content elements of type Text. The first header is in the Header-field, the second header is in the Text-field.

In frontend-editing (tested in 1.3.0), the div with contenteditable appears after the h1-tag instead of inside. The effect of this is that it's not really clear that it's a header that you are editing.

selection_087

@mabolek mabolek added wontfix documentation Add to documentation labels Feb 5, 2019
@mabolek
Copy link
Collaborator

mabolek commented Feb 5, 2019

@pxamike If I understand you correctly, this isn't a bug.

Technically, a rich text field can contain anything. Best practice would be to leave headers out of the rich text field.

I'm marking this as something we should add to the documentation. Integrators should maybe consider disabling headers in rich text fields.

@erredeco
Copy link

erredeco commented Jan 23, 2020

I have the same issue on 1.9.0 and honestly, it is a bug and not a documentation problem: It happens when you have a textarea in your content element (like the plain TYPO3 "Text"), it changes the appearance of the page and, worst, it makes impossible for example to edit the whole content element itself.
It happens also with "Header" content element.
It happens also with "Table" content element
It does not seem to happen with "Text and Images" content element

@Messj1
Copy link
Contributor

Messj1 commented Feb 24, 2021

@mabolek I think you didn't understand correctly.

@pxamike If I understand you correctly, this isn't a bug.

Technically, a rich text field can contain anything. Best practice would be to leave headers out of the rich text field.

I'm marking this as something we should add to the documentation. Integrators should maybe consider disabling headers in rich text fields.

And the screenshot shows definitely that the h1 content was on a wrong place and the class was not proper set:

<div data-field="bodytext" ...>
  <div>
    <h1 class>...</h1>
    <div data-field="header" ...><!-- h1 content (content header) --></div>
    <div data-field="bodytext" ...>
      ...
    </div>
  </div>
</div>

But the configuration was wrong as i can see on the first data-field parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Add to documentation wontfix
Projects
None yet
Development

No branches or pull requests

4 participants