Skip to content

Commit

Permalink
[TASK] Option to disable Frontend Editing loading screen (#724)
Browse files Browse the repository at this point in the history
Resolves: #723
  • Loading branch information
webian authored Sep 26, 2023
1 parent 2a68dbd commit 2bcddc4
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 1 deletion.
1 change: 1 addition & 0 deletions Classes/Controller/FrontendEditingModuleController.php
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,7 @@ public function showAction(ServerRequestInterface $request): ResponseInterface
$this->view->assign('protocol', $request->getUri()->getScheme());
$this->view->assign('contentItems', $this->getContentItems());
$this->view->assign('customRecords', $this->getCustomRecords());
$this->view->assign('disableLoadingScreen', (int)(ConfigurationUtility::getExtensionConfiguration()['disableLoadingScreen'] ?? 0));
$this->view->assign('loadingIcon', $this->iconFactory->getIcon('spinner-circle-dark', Icon::SIZE_LARGE)->render());

$this->initFrontendEditingGui();
Expand Down
3 changes: 3 additions & 0 deletions Resources/Private/Language/locallang_be.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
<trans-unit id="extension_management.placeholders">
<source>Enable placeholders and direct drop-to-edit without modal.</source>
</trans-unit>
<trans-unit id="extension_management.disable_loading_screen">
<source>Disable Frontend Editing loading screen.</source>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 3 additions & 1 deletion Resources/Private/Templates/FrontendEditingModule/Show.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
<iframe id="tx_frontendediting_iframe" src="{url}"></iframe>
<div style="display: none;" class="scrollarea scrollarea--arrow scrollarea-top scrollarea--arrow-up"></div>
<div style="display: none;" class="scrollarea scrollarea--arrow scrollarea-bottom scrollarea--arrow-down"></div>
<div class="t3-frontend-editing__loading-screen">{loadingIcon -> f:format.raw()}</div>
<f:if condition="!{disableLoadingScreen}">
<div class="t3-frontend-editing__loading-screen">{loadingIcon -> f:format.raw()}</div>
</f:if>
</div>
</f:if>
</f:section>
3 changes: 3 additions & 0 deletions ext_conf_template.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,6 @@ contentEditableWrapperTagName = div

# cat=features/enable/10; type=boolean; label=LLL:EXT:frontend_editing/Resources/Private/Language/locallang_be.xlf:extension_management.placeholders
enablePlaceholders = 1

# cat=features/enable/20; type=boolean; label=LLL:EXT:frontend_editing/Resources/Private/Language/locallang_be.xlf:extension_management.disable_loading_screen
disableLoadingScreen = 0

0 comments on commit 2bcddc4

Please sign in to comment.