Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updateUser from Interface #2896

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Fix updateUser from Interface #2896

merged 1 commit into from
Mar 1, 2019

Conversation

libertjeremy
Copy link

The updateUser statement in Doctrine/UserManager.php is not compatible with the UserManagerInterface.php interface.

From UserManagerInterface.php :
public function updateUser(UserInterface $user);

From Doctrine/UserManager.php :
public function updateUser(UserInterface $user, $andFlush = true)

@XWB XWB merged commit 5d21457 into FriendsOfSymfony:master Mar 1, 2019
@XWB
Copy link
Member

XWB commented Mar 1, 2019

Thanks.

@guilliamxavier
Copy link

@XWB Please revert:

  • The premise

The updateUser statement in Doctrine/UserManager.php is not compatible with the UserManagerInterface.php interface.

was wrong, it was already compatible (of course!): https://3v4l.org/4tIPJ

Please revert, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants