Refactored the update of the hashed password and canonical fields #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
force-pushed
the
field_updaters
branch
from
3bc6d57 to
d4aca57
Compare
|
👍 |
1 similar comment
|
👍 |
| { | ||
| $plainPassword = $user->getPlainPassword(); | ||
|
|
||
| if (0 === strlen($plainPassword)) { |
There was a problem hiding this comment.
CS and this can be optimized to if ('' === $plainPassword) {
There was a problem hiding this comment.
no, because this would not handle null anymore
stof
changed the title
stof
force-pushed
the
field_updaters
branch
2 times, most recently
from
d2b1d51 to
bbcc4b7
Compare
The responsibility of updating these fields is moved to dedicated services instead of being in the UserManager, allowing to inject them in the Doctrine listener and the validator initializer without any issue about circular dependencies.
|
👍 |
|
@XWB FYI, I have further improvements in my mind following this:
These will come in separate PRs. |
|
Yes we should make the salt optional before 2.0 goes final. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The responsibility of updating these fields is moved to dedicated services instead of being in the UserManager, allowing to inject them in the Doctrine listener and the validator initializer without any issue about circular dependencies.
This PR currently includes #1612 as they would conflict together otherwise. I will need to be rebased once the other PR is merged.This is a BC break for people extending the user manager (or instantiating the existing one themselves, but this would be weird) as the constructor signature has changed.