Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protection against rosetta flash attacks #201

Merged
merged 1 commit into from Dec 16, 2015
Merged

Protection against rosetta flash attacks #201

merged 1 commit into from Dec 16, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jul 15, 2015

This is a rather important security patch. It adds a comment at the beginning of jsonp responses. Instead of

fos.Router.setData(...)

you get

/**/fos.Router.setData(...)

willdurand added a commit that referenced this pull request Dec 16, 2015
Protection against rosetta flash attacks
@willdurand willdurand merged commit d30173e into FriendsOfSymfony:master Dec 16, 2015
@guilliamxavier
Copy link
Contributor

Since the current, maintained and stable version is 1.6 (latest 1.6.2) and there is no stable 2.0 yet, could this "security patch" be also merged in branch 1.x, and a new tag (1.6.3 or maybe 1.7.0) released? (If not, could someone please explain why?) Thanks

@guilliamxavier
Copy link
Contributor

@tobias-93 and @GuilhemN (based on symfony/symfony-docs#8250): following the example of #286, I have submitted a PR in the hope it will help this be merged to 1.x (unless you plan to release a stable 2.0 in the [very] short term?), see #292 (actually 4 PRs, 291 to 294, all really straightforward)

@tobias-93
Copy link
Collaborator

@guilliamxavier Thank you for your good work, they all look good to me. However, I'm not in the position to merge this (the 'issue' in symfony/symfony-docs#8250 isn't closed either)... Maybe @GuilhemN or @willdurand could have a look?

@GuilhemN
Copy link
Member

@tobias-93 sorry I don't have much time to dedicate to this, I added you as collaborator so that you can merge it if you think it's ready.

@tobias-93
Copy link
Collaborator

@GuilhemN That's ok. Thank you, I'll have a look!

@guilliamxavier
Copy link
Contributor

@tobias-93 Many thanks for the backports and the new tag/release, I just successfully received the fixes with a composer update (to 1.6.3) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants