facebook_login_url() #99
Conversation
|
PR is a bit too javacripty for my area expertise .. i noticed the "todo" .. do you want to have this PR merged in its current state? |
| */ | ||
| public function getLoginUrl($parameters = array()) | ||
| { | ||
| return $this->container->get('fos_facebook.helper')->loginUrl($parameters); |
There was a problem hiding this comment.
This is not goal of PR, but what about injecting helper via constructor and decline injecting container?
There was a problem hiding this comment.
@Koc Circular reference issue AFAICS (btw, the real place to solve it would be the helper, not the Twig extension as the helper would probably break because of a circular reference if you activate the PhpEngine without activating another engine)
|
@lsmith77 , @kriswallsmith ping |
|
too many changes for this todo: https://github.com/Koc/FOSFacebookBundle/commit/c98c529a70b954fc345c04cb0213b33a0d08d806 (not tested yet + I've breaked newlines). Imho better merge without it. |
This adds a function to return the Facebook login URL. This is handy if you are using the Javascript SDK but want a hard-coded href in place in case Javascript is off.