chore: enable phpstan (#31)

* chore: enable phpstan

* chore: bump js deps

.github/workflows/backend.yml

@@ -0,0 +1,12 @@
+name: FoF Prevent Necrobumping PHP
+
+on: [workflow_dispatch, push, pull_request]
+
+jobs:
+  run:
+    uses: flarum/framework/.github/workflows/REUSABLE_backend.yml@main
+    with:
+      enable_backend_testing: false
+      enable_phpstan: true
+
+      backend_directory: .

.github/workflows/build.yml → .github/workflows/frontend.yml

@@ -1,4 +1,4 @@
-name: Javascript
+name: FoF Prevent Necrobumping JS
 
 on: [workflow_dispatch, push, pull_request]
 
@@ -8,11 +8,12 @@ jobs:
     with:
       enable_bundlewatch: false
       enable_prettier: true
-      enable_typescript: false
+      enable_typescript: true
 
       frontend_directory: ./js
       backend_directory: .
       js_package_manager: npm
       main_git_branch: master
+
     secrets:
       bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}

composer.json

@@ -44,11 +44,27 @@
                 "color": "#fff"
             },
             "optional-dependencies": [
-              "flarum/tags"
+                "flarum/tags"
             ]
         },
         "flagrow": {
             "discuss": "https://discuss.flarum.org/d/18312"
+        },
+        "flarum-cli": {
+            "modules": {
+                "githubActions": true
+            }
         }
+    },
+    "require-dev": {
+        "flarum/phpstan": "*",
+        "flarum/tags": "*"
+    },
+    "scripts": {
+        "analyse:phpstan": "phpstan analyse",
+        "clear-cache:phpstan": "phpstan clear-result-cache"
+    },
+    "scripts-descriptions": {
+        "analyse:phpstan": "Run static analysis"
     }
 }

js/package.json

@@ -7,11 +7,11 @@
     "@flarum/prettier-config": "^1.0.0",
     "flarum-tsconfig": "^1.0.2",
     "flarum-webpack-config": "^2.0.0",
-    "webpack": "^5.76.0",
-    "webpack-cli": "^4.10.0"
+    "webpack": "^5.89.0",
+    "webpack-cli": "^5.1.4"
   },
   "devDependencies": {
-    "prettier": "^2.7.1"
+    "prettier": "^3.0.3"
   },
   "scripts": {
     "dev": "webpack --mode development --watch",

phpstan.neon

@@ -0,0 +1,13 @@
+includes:
+  - vendor/flarum/phpstan/extension.neon
+
+parameters:
+  # The level will be increased in Flarum 2.0
+  level: 5
+  paths:
+    - extend.php
+    - src
+  excludePaths:
+    - *.blade.php
+  checkMissingIterableValueType: false
+  databaseMigrationsPath: ['migrations']

src/Listeners/ValidateNecrobumping.php

@@ -20,7 +20,11 @@
 
 class ValidateNecrobumping
 {
+    /**
+     * @var NecrobumpingPostValidator
+     */
     protected $validator;
+
     /**
      * @var SettingsRepositoryInterface
      */
@@ -34,7 +38,7 @@ public function __construct(NecrobumpingPostValidator $validator, SettingsReposi
 
     public function handle(Saving $event)
     {
-        if ($event->post->exists || $event->post->number == 1) {
+        if ($event->post->exists || $event->post->number === 1) {
             return;
         }
 

src/Util.php

@@ -19,6 +19,7 @@ class Util
     public static function getDays(SettingsRepositoryInterface $settings, Discussion $discussion): ?int
     {
         $days = $settings->get('fof-prevent-necrobumping.days');
+        /** @phpstan-ignore-next-line */
         $tags = $discussion->tags;
 
         if ($tags && $tags->isNotEmpty()) {