Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: buttons on security page dont work #81

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: buttons on security page dont work #81

merged 1 commit into from
Sep 11, 2024

Conversation

luceos
Copy link
Contributor

@luceos luceos commented Sep 4, 2024

Fixes #79

Changes proposed in this pull request:

The in-use Button has no path method, moved to Link and using external as otherwise the link would be redirect to the community index instead.

Reviewers should focus on:

Screenshot

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

@DavideIadeluca DavideIadeluca merged commit f0de176 into FriendsOfFlarum:master Sep 11, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavideIadeluca DavideIadeluca DavideIadeluca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buttons in settings - security - linked accounts not working
2 participants
@luceos @DavideIadeluca