-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Fully permissions based links #70
Conversation
imorland
commented
Sep 19, 2024
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things that could be improved but are not blocking.
One issue which we need to resolve in any case are the down migrations. It seems like the visibility
column is not added back, which will result in the Forum Frontend Crashing Column not found: 1054 Unknown column 'visibility' in 'where clause'
.
Also, after downgrading and trying to purge the extension, a MigrationKeyMissing
error will be raised. Both issues are most likely related.
Co-authored-by: Davide Iadeluca <[email protected]>
Co-authored-by: Davide Iadeluca <[email protected]>
Co-authored-by: Davide Iadeluca <[email protected]>
Running the migrations down after a downgrade is a scenario that is not supported in Flarum, if changes were made in the new version. To purge data in this way, the purge must be done from the current version for it to work correctly. I identified a small issue with a migration from 2020, but no issues with the new migrations |