Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fully permissions based links #70

Merged
merged 32 commits into from
Oct 14, 2024
Merged

feat: Fully permissions based links #70

merged 32 commits into from
Oct 14, 2024

Conversation

imorland
Copy link
Member

@imorland imorland commented Sep 19, 2024

image
image
image

@imorland imorland changed the title chore: refactor to use model visibility feat: Fully permissions based links Oct 11, 2024
@DavideIadeluca DavideIadeluca added the enhancement New feature or request label Oct 11, 2024
Copy link
Member

@DavideIadeluca DavideIadeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things that could be improved but are not blocking.

One issue which we need to resolve in any case are the down migrations. It seems like the visibility column is not added back, which will result in the Forum Frontend Crashing Column not found: 1054 Unknown column 'visibility' in 'where clause'.

Also, after downgrading and trying to purge the extension, a MigrationKeyMissing error will be raised. Both issues are most likely related.

js/src/admin/components/EditLinkModal.js Outdated Show resolved Hide resolved
js/src/admin/components/EditLinkModal.js Outdated Show resolved Hide resolved
js/src/admin/components/EditLinkModal.js Outdated Show resolved Hide resolved
locale/en.yml Outdated Show resolved Hide resolved
locale/en.yml Outdated Show resolved Hide resolved
@imorland
Copy link
Member Author

Some minor things that could be improved but are not blocking.

One issue which we need to resolve in any case are the down migrations. It seems like the visibility column is not added back, which will result in the Forum Frontend Crashing Column not found: 1054 Unknown column 'visibility' in 'where clause'.

Also, after downgrading and trying to purge the extension, a MigrationKeyMissing error will be raised. Both issues are most likely related.

Running the migrations down after a downgrade is a scenario that is not supported in Flarum, if changes were made in the new version. To purge data in this way, the purge must be done from the current version for it to work correctly.

I identified a small issue with a migration from 2020, but no issues with the new migrations

@imorland imorland merged commit 652a948 into master Oct 14, 2024
32 checks passed
@imorland imorland deleted the im/refactor-test branch October 14, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants