chore: refactor services to eliminate code duplication #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR introduces several enhancements to
fof/geoip
. The primary change is the introduction of a base class for the GeoIP services, which refactors and streamlines the service implementations.Additionally, a trait for handling
GeoIP
errors has been added, and localization updates have been made.Key Changes:
Api/Services/BaseGeoService.php
. This abstracts away common functionality from the individual service classes, providing a cleaner and more standardized approach.IPApi
,IPData
,IPLocation
, andIPStack
have been refactored to extend this new base class.Traits/HandlesGeoIPErrors.php
. This trait provides a method to handleGeoIP
errors and is used in theGeoIP
class.GeoIP
class has been updated to use the shorthand syntax for property promotion.RetrieveIP
class has been updated to use the contract for the cache repository instead of the concrete implementation..