Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for wkhtmltopdf binary. #308

Merged
merged 1 commit into from
Dec 26, 2020
Merged

Fix check for wkhtmltopdf binary. #308

merged 1 commit into from
Dec 26, 2020

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Dec 26, 2020

Refs #304

@codecov
Copy link

codecov bot commented Dec 26, 2020

Codecov Report

Merging #308 (6fc6c71) into master (21c0de1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #308   +/-   ##
=========================================
  Coverage     52.02%   52.02%           
  Complexity      212      212           
=========================================
  Files            10       10           
  Lines           544      544           
=========================================
  Hits            283      283           
  Misses          261      261           
Impacted Files Coverage Δ Complexity Δ
src/Pdf/Engine/WkHtmlToPdfEngine.php 69.23% <100.00%> (ø) 32.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c0de1...6fc6c71. Read the comment docs.

@ADmad ADmad merged commit 8146a19 into master Dec 26, 2020
@ADmad ADmad deleted the wkhtmltopdf-binary branch December 26, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant