Don't remove root element from the DOM on destroy #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gzuidhof
approved these changes
May 30, 2024
| @@ -352,7 +352,9 @@ export class FriendlyCaptchaSDK { | |||
| send({ type: "root_destroy_widget" }); | |||
| this.bus.removeTarget(widgetId); | |||
| this.widgets.delete(widgetId); | |||
| opts.element.remove(); | |||
|
|
|||
| opts.element.innerHTML = ""; | |||
There was a problem hiding this comment.
I believe this may trigger CSP setups without unsafe-inline (but I'm not entirely sure: you could validate by writing a test for it in sdktest). If it does pose a problem, I imagine we can loop over the children and remove them one by one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The element that the widget is bound to is not created by it and should therefore not be removed from the DOM when the widget is destroyed. Instead, this removes all children and the styling.