Various improvements / proposition #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MangelMaxime
changed the title
netstandard2.0
|
Thanks a lot for the improvements. I will look at it on monday morning! |
Freymaurer
approved these changes
Nov 20, 2023
|
@MangelMaxime release should be published on nuget in a few minutes 👍 Thanks again for the contribution |
|
Awesome thank you, it got rid of the errors I had in Thoth.Json.Python 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @Freymaurer ,
I am currently working on the Python version of Thoth.Json and want to you your library as it allows to the same API for running tests against .NET, JavaScript and Python.
While doing so, I discovered that the library target
net6.0which means that user also have to use that target. In general, we make library targetnetstandard2.0as it allows to consume the library across a lot of different target framework.I also took this opportunity to lower the version of
FSharp.Corerequired, otherwise users will have warnings about a downgrade in their code:While testing locally, I saw that the build system was using expecting python to be at
pyhowever this is not standard. So I took this opportunity to use the standardpythonexecutable.