Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add missing zone info #10

Merged
merged 4 commits into from
Dec 22, 2022
Merged

feat: add missing zone info #10

merged 4 commits into from
Dec 22, 2022

Conversation

24367dfa
Copy link
Contributor

solves #6

penguineer
penguineer requested changes Dec 19, 2022
View reviewed changes
Copy link
Member

@penguineer penguineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich habe zwei Änderungswünsche:

  • Die Einrückung passt nicht zum Rest (jedenfalls im Diff)
  • Es fehlt ein abschließendes Zeilenende

@penguineer
Copy link
Member

solves #6

Only partially unfortunately. I have added a list of hosts that need to be in the zone file.

@penguineer
Copy link
Member

Das könnte dann nach #11 kommen, damit wir die Pipeline gleich nutzen können. :)

@24367dfa 24367dfa changed the title feat: add missing zone info Draft: feat: add missing zone info Dec 20, 2022
@24367dfa
Copy link
Contributor Author

Ich habe zwei Änderungswünsche:

  • Die Einrückung passt nicht zum Rest (jedenfalls im Diff)
  • Es fehlt ein abschließendes Zeilenende

Fixed in 8841423

@24367dfa
Copy link
Contributor Author

24367dfa commented Dec 20, 2022 •
edited
Loading

solves #6

Only partially unfortunately. I have added a list of hosts that need to be in the zone file.

except for gw1 the missing adresses were added in 55bf8fd

@24367dfa 24367dfa marked this pull request as draft December 20, 2022 12:12
@24367dfa 24367dfa changed the title Draft: feat: add missing zone info feat: add missing zone info Dec 20, 2022
@24367dfa 24367dfa linked an issue Dec 20, 2022 that may be closed by this pull request
Zoneninfos ffmd sind unvollständig #6
Closed
6 tasks
@24367dfa 24367dfa added the enhancement New feature or request label Dec 20, 2022
@24367dfa 24367dfa marked this pull request as ready for review December 20, 2022 13:24
@24367dfa
Copy link
Contributor Author

24367dfa commented Dec 20, 2022 •
edited
Loading

rebase ist durch, die requested changes auch. irgendwie bekomme ich das aber nicht als resolved markiert -.-

@penguineer
Copy link
Member

rebase istr durch, die requested changes auch. irgendwie bekomme ich das aber nicht als resolved markiert -.-

Das muss ich machen, indem ich ein neues Review anlegen. Ich würde aber noch auf #11 warten, damit wir das gleich nutzen können.

@penguineer
Copy link
Member

@24367dfa Kannst Du diesen Branch bitte noch einmal zum aktuellen HEAD rebasen?

@24367dfa
Copy link
Contributor Author

@24367dfa Kannst Du diesen Branch bitte noch einmal zum aktuellen HEAD rebasen?

/done

@penguineer penguineer merged commit c1cd371 into master Dec 22, 2022
@penguineer penguineer deleted the 6-fix-missing-zone-info branch December 22, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penguineer penguineer penguineer approved these changes

@christf christf Awaiting requested review from christf

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Zero Maintenance Revamp
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zoneninfos ffmd sind unvollständig
2 participants
@24367dfa @penguineer