Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed logtime fill color bug #77

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NorielSylvire
Copy link

Hi!
For some reason, the color of the text in the logtime view looked correct, but the background color was always the default one:
before1
before2

This happens for anyone who uses this extension. I've asked multiple people and they experience the same issue.

So I made a JS function that overrides the background color based on the user's selected theme color and the number of hours they've spent logged in.
I made it so that it never reaches full saturation. The color tops out at around 19 to 20 hours and from there it doesn't get more intense because otherwise the date wouldn't be readable:

after1 after2

I think it's a good enough approximation of how this used to work and most people won't ever spent over 19h logged in anyways.

I tried making this in CSS but I don't know how to get the number of hours in CSS and they're required for the calculation.

@FreekBes
Copy link
Owner

Hello! Thank you for your pull request.

Are you sure this bug still occurs since version 4.3.0, released last January? Commit 9140a94 fixed the same issue, but perhaps the it reappeared.

@FreekBes FreekBes added bug Something isn't working theme bug Something doesn't look right labels Apr 28, 2024
@NorielSylvire
Copy link
Author

NorielSylvire commented May 12, 2024

Hello, apologies for the late response, I didn't get the notification!

I just went to the chrome extension store and hit the "Get extension" button. I still get the same issue. HOWEVER letme clone this repo and use this instead real quick.

Okay so when using the unpacked version cloned from this repo, while not authenticated it "works" but uses a default (blue) color. When I authenticate myself and select my preferred (red) color, it still doesn't work, and displays exactly the same way as in the first two pictures.

I have also observed the same problem in other people's computers with their own intra users and session, so I don't think it's specifically a problem with my setup/session.

I've also tried deleting the cache but it didn't work. And this also happens at home.

NOTE: all of my campus' computers, and my personal laptop use Ubuntu + Google Chrome. I haven't tried it on Mac or Windows yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working theme bug Something doesn't look right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants