FtRadioButton and FtCheckboxList v-model and composition API #6463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
Works like a charm
This PR does not improve the performance |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 28, 2024
|
we discovered that the performance issues i was seeing were related to something else. That will be resolved in an upcoming PR |
1 task
PikachuEXE
approved these changes
Dec 29, 2024
kommunarr
approved these changes
Dec 29, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Dec 30, 2024
* development: (75 commits) Bump lefthook from 1.10.0 to 1.10.1 (FreeTubeApp#6480) Bump bgutils-js from 3.1.0 to 3.1.1 (FreeTubeApp#6482) Translated using Weblate (Estonian) Translated using Weblate (Serbian) Translated using Weblate (Polish) Translated using Weblate (Czech) Translated using Weblate (English (United Kingdom)) Translated using Weblate (Hungarian) Translated using Weblate (Hungarian) Translated using Weblate (German) Translated using Weblate (Italian) Translated using Weblate (French) Translated using Weblate (Chinese (Simplified Han script)) FtRadioButton and FtCheckboxList v-model and composition API (FreeTubeApp#6463) Disable store strict mode, due to performance problems because of the amount of data in the store (FreeTubeApp#6469) [Feature] Playlist: Sort videos by published date (FreeTubeApp#6280) Migrate ChannelAbout to the composition API (FreeTubeApp#6470) Translated using Weblate (German) compress frappe svgs (FreeTubeApp#6467) Translated using Weblate (Hungarian) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FtRadioButton and FtCheckboxList v-model and composition API
Pull Request Type
Related issue
Description
This pull request migrates the FtRadioButton and FtCheckboxList components to the composition API and implements the component v-model system for them. The component v-model setup allows us to get rid of the dodgy watching properties on the refs and calling methods on them setup that we previously had, simplifying it to just refs and watchers. This avoids extra component updates as now only those who's data actually changed get updated/re-rendered and we also only make calls to the store for values that actually changed.
Hopefully this improves the performance, if not then at least we've migrated two more components to the composition API and still have less complicated code in the FtSearchFilters component.
In Vue 3.4 the Vue developers introduced the
defineModel()compiler macro which takes away the boilerplate of the component v-model implementation, so we'll be able to simplify the code even further when we update to Vue 3. The backport of the compositon API into Vue 2.7 happened well before the Vue 3.4 release, so we don't have access to the macro in Vue 2.7.Testing
Test that the search filters still work correctly.
@efb4f5ff-1298-471a-8973-3d47447115dc Please also test that this improves the performance of the search filters.
Desktop