Filter our members-only section on channel home pages #6437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Dec 23, 2024
ChunkyProgrammer
approved these changes
Dec 23, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 23, 2024
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter our members-only section on channel home pages
Pull Request Type
Related issue
Description
On channels that support paid memberships YouTube displays a members-only videos section on the home tab based on the auto-generated channel members-only playlist. As none of the videos in that section can be played in FreeTube I think it makes sense to hide it. As YouTube doesn't show those videos in search results or on the videos channel tab, the channel home tab is the most likely place for people to discover them (unless the video is explicitly mentioned in a public community post).
On YouTube itself it makes sense to show that section as logged in users just need to sign up for the channel membership and can view the videos but as we don't support logging in with a YouTube account in FreeTube and don't plan to either, I don't think it makes sense to make it easier for the user to find videos that they can't play.
Screenshots
Before
After
Testing
Visit https://youtube.com/@LinusTechTips and check that the member-only section is hidden.
Desktop