Switch back to the WEB client for the local API with potokens #6436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
PR: dependencies
PikachuEXE
previously approved these changes
Dec 23, 2024
|
Post merge action: merge FreeTubeApp/FreeTube-Docs#157 |
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
ofcourse... |
|
It's because autolinker and bgutils-js are next to each other in the package.json file :/ |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
absidue
added
the
PR: waiting for review
PikachuEXE
approved these changes
Dec 23, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 27, 2024
kommunarr
approved these changes
Dec 27, 2024
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch back to the WEB client for the local API with potokens
Pull Request Type
Related issue
Description
This pull request switches back to the WEB client as a way to hopefully avoid the 403s that have started to appear for some people. As an added bonus this means we can use the DASH manifests for live streams which have 4 hours of seeking, the alternative would be to use the HLS manifest but as the WEB ones don't support audio-only or seeking, using the DASH ones seemed like a better idea.
To make this possible, I added the
bgutils-jsdependency to help generate the poTokens required for using the WEB client these days. As the BotGuard code accesses the globalwindowanddocumentobjects, I decided it would be best to isolate it to its own webview with a separate temporary session and reduced permissions compared to our normal webviews that the user interacts with. That also required introducing a separate webpack config to be able to generate the script to run inside of that webview.Testing
Test video playback with the local API, both normal videos and live streams. If you can find a movie with a trailer that isn't dubbed you can test that too (dubbed trailers are known to be an issue, i'll be creating a PR to youtube.js to fix the DASH manifest generation).
Desktop