Migrate Trending to the composition API #6397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
|
If i manually refresh one feed the others will also refresh when i navigate to them. This makes testcase 2 harder to test VirtualBoxVM_XkeT9hh1aV.mp4 |
|
That is the same as it was before. I probably should have specified in the pull request description that this pull request just migrated the component to the composition API and didn't try to fix any bugs (like other pull requests have in the past), so this time you are mainly testing that it works the same as on the development branch. |
ChunkyProgrammer
approved these changes
Dec 17, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 17, 2024
PikachuEXE
approved these changes
Dec 18, 2024
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Trending to the composition API
Pull Request Type
Description
This pull request migrate the Trending component to the composition API.
Testing
Desktop